This repository was archived by the owner on Dec 3, 2019. It is now read-only.
Switch to LIFO for object pool strategy #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch to use a stack datastructure to store connections. Current implementation uses FIFO strategy, which prevents unused connections from being closed because object pool goes through all connections. With LIFO strategy, unused connections will stay at the bottom of the stack and will be cleaned up during `testObjects` call. Additionally, declare `waitQueue` as `Queue` for clarity.
Contributor
Author
There was a problem hiding this comment.
because of line 244: this.poolables = this.poolables.diff(removals). Unfortunately mutable.Stack doesn't support removing elements that are not the top item, as far as I know.
Owner
|
Thanks @pitr ! |
mauricio
added a commit
that referenced
this pull request
Dec 16, 2015
Switch to LIFO for object pool strategy
Contributor
Author
|
oh, i expected more scrutiny :) thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to use a stack datastructure to store connections. Current implementation uses FIFO strategy, which prevents unused connections from being closed because object pool goes through all connections. With LIFO strategy, unused connections will stay at the bottom of the stack and will be cleaned up during
testObjectscall.Additionally, declare
waitQueueasQueuefor clarity.