This repository was archived by the owner on Dec 3, 2019. It is now read-only.
Added types field to MutableResultSet. This will allow inferring the … #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…types of RowData fields, which can be useful in different situations, e.g. converting the results to json format
mauricio
added a commit
that referenced
this pull request
Aug 26, 2015
Added types field to MutableResultSet. This will allow inferring the …
Contributor
Author
|
Thanks for merging in. Will you be publishing the 0.2.19-SNAPSHOT to a repo On Wed, Aug 26, 2015 at 2:00 PM, Maurício Linhares <[email protected]
Best, |
|
I assume the new 'types' field is not going to be used that often. (MutableResultSet has existed until now without it.) If so, then way is it being computed on class construction? Would it be better being a 'lazy val' so that it is computed the first time the field is accessed? |
Owner
|
Yeah, might be better as a lazy val for now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…types of RowData fields, which can be useful in different situations, e.g. converting the results to json format