pack() without args return empty string.
#5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem occurs when lua_Number is double and lua_Integer is int32 In this case `mp.unpack(mp.pack(0xFFFFFFFF)) == -1`
The problem occurs when lua_Number is double and lua_Integer is int32 In this case `mp.unpack(mp.pack(0xFFFFFFFF)) == -1` (Originally each sizeof() check was for sizeof < 64, which didn't make sense. Committer changed it to check for sizeof == 4 instead.)
The 0xFFFFFFFF test can potentially fail on 32 bit systems if our internal conversions are casting to wrong Lua types. lua_Integer != lua_Number
…-tests' into add-streaming-and-refactor-and-tests
mattsta
force-pushed
the
add-streaming-and-refactor-and-tests
branch
5 times, most recently
from
23d6f07 to
afbc009
Compare
…-tests' into add-streaming-and-refactor-and-tests Conflicts: lua_cmsgpack.c test.lua
|
What do you think. This PR is useless now but it quite simple change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now
pack()raise error butunpack("")return nothing.I use cmsgpack to RPC so this is convinient to be able call
ret = mp.pack( fn(...) )and pass returns values as is.