test typescriptification - spec/integ #2714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
September 16, 2022 15:28
…/matrix-client-event-emitter.spec.ts
…x-client-methods.spec.ts
…lient-opts.spec.ts
…/matrix-client-room-timeline.spec.ts
turt2live
reviewed
Sep 29, 2022
Member
turt2live
left a comment
turt2live
left a comment
There was a problem hiding this comment.
clearing code review while draft
added 6 commits
September 30, 2022 11:41
duxovni
suggested changes
Sep 30, 2022
Contributor
duxovni
left a comment
duxovni
left a comment
There was a problem hiding this comment.
The expects that can be compressed into one line are just a nitpick, mostly focused on the un-cleaned-up httpBackends and the ==s.
| // Alice should be tracking bob's device list | ||
| expect(bobStat).toBeGreaterThan( | ||
| 0, "Alice should be tracking bob's device list", | ||
| 0, |
Contributor
There was a problem hiding this comment.
May as well just make this a single line
| // Alice should have marked bob's device list as untracked | ||
| expect(bobStat).toEqual( | ||
| 0, "Alice should have marked bob's device list as untracked", | ||
| 0, |
| // Alice should have marked bob's device list as untracked | ||
| expect(bobStat).toEqual( | ||
| 0, "Alice should have marked bob's device list as untracked", | ||
| 0, |
| // Alice should have marked bob's device list as untracked | ||
| expect(bobStat).toEqual( | ||
| 0, "Alice should have marked bob's device list as untracked", | ||
| 0, |
Comment on lines
103
to
105
| expect(expectedEventTypes.indexOf(event.getType())).not.toEqual( | ||
| -1, "Recv unexpected event type: " + event.getType(), | ||
| -1, | ||
| ); |
Contributor
There was a problem hiding this comment.
This can also be a one-liner now
Comment on lines
122
to
124
| expect(expectedEventTypes.length).toEqual( | ||
| 0, "Expected to see event types: " + expectedEventTypes, | ||
| 0, | ||
| ); |
duxovni
approved these changes
Oct 6, 2022
Contributor
duxovni
left a comment
duxovni
left a comment
There was a problem hiding this comment.
Looks good, there's still the == here but it's a minor nitpick in the context of a test.
Comment on lines
+74
to
75
| if (!(req.queryParams?.access_token == accessToken || | ||
| req.headers["Authorization"] == "Bearer " + accessToken)) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The final instalment of test typescriptification 🥳
Fixes #2353
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.