MNT/TST: fill out the data-model and update tests #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytest no longer supports them. Did this by just calling the helper functions in-line. It does make the tests bigger, but this changes the testing code in the minimal way possible.
|
This pull request fixes 2 alerts when merging 0d75afa into 16010dd - view on LGTM.com fixed alerts:
Comment posted by LGTM.com |
timhoffm
approved these changes
May 19, 2019
Member
|
CI failures are due to version incompatibilities of |
Codecov Report
@@ Coverage Diff @@
## master #52 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 181 184 +3
Branches 51 51
=====================================
+ Hits 181 184 +3
Continue to review full report at Codecov.
|
Member
Author
|
Let see if upstream has sorted them selves out... |
|
This pull request fixes 2 alerts when merging f28a407 into 16010dd - view on LGTM.com fixed alerts:
|
ImportanceOfBeingErnest
approved these changes
Sep 13, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started out trying to get rid of the two warings in LGTM, ended up
modernizing the test suite....