Doc adjustments for v1 #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mw-hrastega
reviewed
May 18, 2021
README.md
Outdated
| - To use a self-hosted runner, you must set up a computer with MATLAB (R2013b or later) as your runner. The action uses the topmost MATLAB version on the runner's system path. | ||
|
|
||
| - To use a GitHub-hosted runner, you must include the [Set Up MATLAB](https://github.com/matlab-actions/setup-matlab/) action in your workflow to install MATLAB on the runner. Currently, this action is available only for public projects. It does not install transformation products, such as MATLAB Coder™ and MATLAB Compiler™. | ||
| - To use a GitHub-hosted runner, you must include the [Setup MATLAB](https://github.com/matlab-actions/setup-matlab/) action in your workflow to install MATLAB on the runner. Currently, this action is available only for public projects. It does not install transformation products, such as MATLAB Coder™ and MATLAB Compiler™. |
Member
There was a problem hiding this comment.
How about the "install" instances in this paragraph? 🤒
Member
There was a problem hiding this comment.
How about the "install" instances in this paragraph? 🤒
good catch! lets say "does not include..."
mcafaro
approved these changes
May 18, 2021
Member
mcafaro
left a comment
mcafaro
left a comment
There was a problem hiding this comment.
+1 replace all instances of "install" with "set up"
mw-hrastega
approved these changes
May 18, 2021
Contributor
Author
|
Oops 😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With us heading into the marketplace real soon, I want to make sure the README will reflect the v1 status and latest discussions on naming 🤔