This repository was archived by the owner on Jan 13, 2025. It is now read-only.
fix(touch-target): incorrect position in rtl when width is set #7169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the `touch-target` mixin produces styles that will set the touch target outside of the host node on RTL layouts (see angular/components#22925). These changes adjust the styles so that the target is always centered.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jun 19, 2021
We had to make some overrides to MDC's touch target styles in RTL, because they didn't align. The issue has been fixed in MDC (material-components/material-components-web#7169) so the workarounds can be cleaned up.
mmalerba
pushed a commit
to angular/components
that referenced
this pull request
Jun 22, 2021
We had to make some overrides to MDC's touch target styles in RTL, because they didn't align. The issue has been fixed in MDC (material-components/material-components-web#7169) so the workarounds can be cleaned up.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
touch-targetmixin produces styles that will set the touch target outside of the host node on RTL layouts (see angular/components#22925). These changes adjust the styles so that the target is always centered.