This repository was archived by the owner on Jan 13, 2025. It is now read-only.
fix(list): density configuration mixins do not account for leading avatars #7021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
brandondiamond
left a comment
brandondiamond
left a comment
There was a problem hiding this comment.
Everything looks great -- let's remove the trailing-padding commit from this PR for now. After that, LGTM to merge!
…atars Currently when someone uses the MDC list w/ evolution styles, it's possible to generate secondary styles with a different density scale. This can be achieved by using the following mixins: * `one-line-item-density` * `two-line-item-density` * `three-line-item-density` These mixins currently do not account for leading avatars, unlike they do for icons, checkboxes, switches, radio's, images and videos. This commit adds code fo leading avatars.
Contributor
Author
|
@brandondiamond I've rebased the PR. Should be ready for merge. |
In Angular Material we have several components that are based on simple, single-line lists. Currently if we were to go through the `without-ripple` mixin, we would end up with a lot of unused styles, because all we care about are the base structural styles, colors and typography. These changes make the `list-base` and `item-base` mixins public so that we have more granular control over the included styles.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(list): density configuration mixins do not account for leading avatars
Currently when someone uses the MDC list w/ evolution styles, it's possible to generate secondary
styles with a different density scale. This can be achieved by using the following mixins:
one-line-item-density,two-line-item-densityandthree-line-item-density.These mixins currently do not account for leading avatars, unlike they do for icons, checkboxes,
switches, radio's, images and videos. This commit adds code fo leading avatars.
refactor(list): expose evolution base mixins
In Angular Material we have several components that are based on simple, single-line lists.
Currently if we were to go through the
without-ripplemixin, we would end up with a lot ofunused styles, because all we care about are the base structural styles, colors and typography.
These changes make the
list-baseanditem-basemixins public so that we have more granularcontrol over the included styles.