Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/core/services/tool_call_reactor_middleware.py
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ async def process(
)

# Create a new response with the replacement content
if result.replacement_response:
if result.replacement_response is not None:
replacement_response = self._create_replacement_response(
response,
result.replacement_response,
Expand Down
44 changes: 44 additions & 0 deletions tests/unit/core/services/test_tool_call_reactor_middleware.py
Original file line number Diff line number Diff line change
Expand Up @@ -306,6 +306,50 @@ async def test_process_with_tool_calls_swallowed(self, middleware, mock_reactor)
assert result.metadata["original"] == "metadata"
assert result.metadata["tool_call_reactor"]["handler"] == "test_handler"

@pytest.mark.asyncio
async def test_process_with_empty_replacement(self, middleware, mock_reactor):
"""Handlers should be able to swallow calls with empty steering content."""

tool_call_response = {
"choices": [
{
"message": {
"tool_calls": [
{
"id": "call_321",
"type": "function",
"function": {
"name": "test_tool",
"arguments": '{"arg": "value"}',
},
}
]
}
}
]
}

response = ProcessedResponse(content=json.dumps(tool_call_response))

swallow_result = ToolCallReactionResult(
should_swallow=True,
replacement_response="",
metadata={"handler": "test_handler"},
)

mock_reactor.process_tool_call.return_value = swallow_result

result = await middleware.process(
response=response,
session_id="test_session",
context={"backend_name": "test", "model_name": "test"},
)

assert isinstance(result, ProcessedResponse)
assert result is not response
assert result.content == ""
assert result.metadata["tool_call_swallowed"] is True

@pytest.mark.asyncio
async def test_process_with_tool_calls_swallowed_merges_metadata(
self, middleware, mock_reactor
Expand Down