Skip to content

use non-secure version of nanoid to avoid missing crypto global in IE11 #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 16, 2022
Merged

use non-secure version of nanoid to avoid missing crypto global in IE11 #429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8dea0c2
use non-secure version of nanoid to avoid missing crypto global in IE11
stomita Jul 16, 2022
3d07c29
fix to use getToday func if date is not passed
stomita Jul 16, 2022
d6f22d2
set NODE_ENV=test env to storycap server running
stomita Jul 16, 2022
44b3228
reset getToday function constant return in test env
stomita Jul 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"scripts": {
"storybook": "start-storybook -s ./node_modules/@salesforce-ux/design-system -p 9001 -c .storybook",
"test": "echo \"no test to run\"",
"pretest:visual": "storycap --serverCmd \"npm run storybook -- --ci\" http://localhost:9001 -o images --serverTimeout 3600000 --captureTimeout 10000 --delay 2000",
"pretest:visual": "storycap --serverCmd \"NODE_ENV=test npm run storybook -- --ci\" http://localhost:9001 -o images --serverTimeout 3600000 --captureTimeout 10000 --delay 2000",
"test:visual": "reg-suit -v run",
"type-check": "tsc --noEmit",
"type-check:watch": "npm run type-check -- --watch",
Expand Down
2 changes: 1 addition & 1 deletion src/scripts/Datepicker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ type Calendar = {
function createCalendarObject(date?: string, mnDate?: string, mxDate?: string) {
let minDate;
let maxDate;
let d = dayjs(date, 'YYYY-MM-DD');
let d = dayjs(date ?? null, 'YYYY-MM-DD');
if (!d.isValid()) {
d = dayjs(getToday(), 'YYYY-MM-DD');
}
Expand Down
4 changes: 2 additions & 2 deletions src/scripts/util.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
import { nanoid } from 'nanoid';
import { nanoid } from 'nanoid/non-secure';
import { updateScroll } from 'react-relative-portal';

export const generateUniqueId: () => string =
process.env.NODE_ENV === 'test' ? () => '$uuid$' : nanoid;

export const getToday =
process.env.NODE_ENV === 'test'
? () => '2017-02-23'
? () => '2022-05-18'
: () => new Date().toISOString().substring(0, 10);

let assetRoot = '/assets';
Expand Down