Skip to content

Conversation

pengzhouml
Copy link
Collaborator

No description provided.

Copilot

This comment was marked as outdated.

@rwinieski rwinieski requested a review from Copilot July 31, 2025 14:23
Copilot

This comment was marked as outdated.

@rwinieski rwinieski requested a review from Copilot August 13, 2025 07:22
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the label and annotation handling system to properly propagate cluster-level labels throughout the codebase. The main change replaces global variables for labels/annotations with context-based storage and methods, ensuring proper scoping and propagation.

Key changes:

  • Replaces global label/annotation variables with context-scoped storage
  • Adds new methods to ClusterContext and OperatorContext for label/annotation management
  • Updates all resource generation functions to use context-based label retrieval

Reviewed Changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
pkg/k8sutil/context.go Adds label/annotation fields to contexts and implements getter/setter methods
pkg/k8sutil/common.go Removes global variables and deprecated label/annotation functions
pkg/k8sutil/handler.go Removes global label/annotation setup calls
pkg/k8sutil/service.go Updates service generation to use context-based label retrieval
pkg/k8sutil/secret.go Updates secret generation to use context-based label retrieval
pkg/k8sutil/networkPolicy.go Updates network policy generation to use context-based label retrieval
pkg/k8sutil/marklogicServer.go Updates MarkLogic group generation to use context-based label retrieval
pkg/k8sutil/ingress.go Updates ingress generation to use context-based label retrieval
pkg/k8sutil/haProxy.go Updates HAProxy configuration to use context-based label retrieval
pkg/k8sutil/configmap.go Updates config map generation to use context-based label retrieval

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

Copy link
Collaborator

@barkhachoithani barkhachoithani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pengzhouml pengzhouml merged commit a8a0439 into develop Aug 15, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants