Skip to content

Conversation

rjrudin
Copy link
Contributor

@rjrudin rjrudin commented Oct 2, 2025

The Bitemp test is failing due to an ml-gradle bug, but I took the opportunity to clean it up so that each test can run separately without depending on the other.

@Copilot Copilot AI review requested due to automatic review settings October 2, 2025 16:16
Copy link

github-actions bot commented Oct 2, 2025

Copyright Validation Results
Total: 5 | Passed: 4 | Failed: 0 | Skipped: 1 | at: 2025-10-02 16:59:28 UTC | commit: 9287224

⏭️ Skipped (Excluded) Files

  • .env

✅ Valid Files

  • marklogic-client-api/src/test/java/com/marklogic/client/test/BitemporalTest.java
  • marklogic-client-api/src/test/java/com/marklogic/client/test/Common.java
  • marklogic-client-api/src/test/java/com/marklogic/client/test/rows/FromSearchWithOptionsTest.java
  • marklogic-client-api/src/test/java/com/marklogic/client/test/ssl/OneWaySSLTest.java

✅ All files have valid copyright headers!

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates several test files to fix failing tests and improve test isolation. The main changes address an ml-gradle bug affecting the Bitemp test and improve test independence by refactoring test setup and teardown methods.

  • Removes Java 8 specific test disabling annotations for TLS 1.3 tests
  • Re-enables previously disabled test methods by removing @disabled annotations
  • Refactors BitemporalTest to use individual test setup/teardown instead of shared class-level methods

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
OneWaySSLTest.java Removes Java 8 TLS compatibility annotations and imports
FromSearchWithOptionsTest.java Re-enables zero score method test by removing @disabled annotation
BitemporalTest.java Major refactoring to use per-test setup/teardown and updated test assertions
.env Updates Docker image configuration comments

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines +18 to +21
import com.marklogic.mgmt.ManageClient;
import com.marklogic.mgmt.resource.temporal.TemporalCollectionLSQTManager;
import jakarta.xml.bind.DatatypeConverter;
import org.custommonkey.xmlunit.exceptions.XpathException;
Copy link
Preview

Copilot AI Oct 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The imports are not organized consistently. Consider grouping standard Java imports together and third-party imports together, with proper alphabetical ordering within each group.

Copilot uses AI. Check for mistakes.

Comment on lines 27 to 28
import java.util.Calendar;
import java.util.Random;
Copy link
Preview

Copilot AI Oct 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The imports are not organized consistently. Consider grouping standard Java imports together and third-party imports together, with proper alphabetical ordering within each group.

Copilot uses AI. Check for mistakes.

Comment on lines +171 to +178
{
"lsqt-enabled": true,
"automation": {
"enabled": true,
"period": 5000
}
}
""";
Copy link
Preview

Copilot AI Oct 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The JSON payload has inconsistent indentation. The opening brace and closing brace should be aligned, and the inner content should use consistent indentation.

Suggested change
{
"lsqt-enabled": true,
"automation": {
"enabled": true,
"period": 5000
}
}
""";
{
"lsqt-enabled": true,
"automation": {
"enabled": true,
"period": 5000
}
}
""";

Copilot uses AI. Check for mistakes.

The Bitemp test is failing due to an ml-gradle bug, but I took the opportunity to clean it up so that each test can run separately without depending on the other.
@rjrudin rjrudin force-pushed the feature/bitemp-bug branch from 93602a5 to 9287224 Compare October 2, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants