-
Notifications
You must be signed in to change notification settings - Fork 74
MLE-24511 Updating a few tests #1833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Copyright Validation Results ⏭️ Skipped (Excluded) Files
✅ Valid Files
✅ All files have valid copyright headers! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates several test files to fix failing tests and improve test isolation. The main changes address an ml-gradle bug affecting the Bitemp test and improve test independence by refactoring test setup and teardown methods.
- Removes Java 8 specific test disabling annotations for TLS 1.3 tests
- Re-enables previously disabled test methods by removing @disabled annotations
- Refactors BitemporalTest to use individual test setup/teardown instead of shared class-level methods
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
File | Description |
---|---|
OneWaySSLTest.java | Removes Java 8 TLS compatibility annotations and imports |
FromSearchWithOptionsTest.java | Re-enables zero score method test by removing @disabled annotation |
BitemporalTest.java | Major refactoring to use per-test setup/teardown and updated test assertions |
.env | Updates Docker image configuration comments |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
import com.marklogic.mgmt.ManageClient; | ||
import com.marklogic.mgmt.resource.temporal.TemporalCollectionLSQTManager; | ||
import jakarta.xml.bind.DatatypeConverter; | ||
import org.custommonkey.xmlunit.exceptions.XpathException; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The imports are not organized consistently. Consider grouping standard Java imports together and third-party imports together, with proper alphabetical ordering within each group.
Copilot uses AI. Check for mistakes.
import java.util.Calendar; | ||
import java.util.Random; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The imports are not organized consistently. Consider grouping standard Java imports together and third-party imports together, with proper alphabetical ordering within each group.
Copilot uses AI. Check for mistakes.
{ | ||
"lsqt-enabled": true, | ||
"automation": { | ||
"enabled": true, | ||
"period": 5000 | ||
} | ||
} | ||
"""; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The JSON payload has inconsistent indentation. The opening brace and closing brace should be aligned, and the inner content should use consistent indentation.
{ | |
"lsqt-enabled": true, | |
"automation": { | |
"enabled": true, | |
"period": 5000 | |
} | |
} | |
"""; | |
{ | |
"lsqt-enabled": true, | |
"automation": { | |
"enabled": true, | |
"period": 5000 | |
} | |
} | |
"""; |
Copilot uses AI. Check for mistakes.
The Bitemp test is failing due to an ml-gradle bug, but I took the opportunity to clean it up so that each test can run separately without depending on the other.
93602a5
to
9287224
Compare
The Bitemp test is failing due to an ml-gradle bug, but I took the opportunity to clean it up so that each test can run separately without depending on the other.