Skip to content

Conversation

rjrudin
Copy link
Contributor

@rjrudin rjrudin commented Oct 1, 2025

Eliminating more warnings, and forcing an error on a compiler warning.

Got rid of two systemProperty values that I don't think are needed, but we'll see what happens in the full test run.

@rjrudin rjrudin requested a review from anu3990 as a code owner October 1, 2025 17:00
@Copilot Copilot AI review requested due to automatic review settings October 1, 2025 17:00
Copy link

github-actions bot commented Oct 1, 2025

Copyright Validation Results
Total: 4 | Passed: 0 | Failed: 0 | Skipped: 4 | at: 2025-10-01 17:20:51 UTC | commit: d9c599a

⏭️ Skipped (Excluded) Files

  • build.gradle
  • gradle.properties
  • marklogic-client-api/build.gradle
  • ml-development-tools/build.gradle

✅ All files have valid copyright headers!

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR focuses on eliminating Gradle build warnings and enforcing stricter compilation standards. The changes modernize Gradle configuration syntax and remove unused properties to create a cleaner build setup.

  • Updates Gradle syntax to use modern enum values and proper property assignment
  • Consolidates Kotlin compilation configuration using newer APIs
  • Removes unused properties and fixes URL protocols for security

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
ml-development-tools/build.gradle Modernizes Gradle syntax, adds missing dependency, and consolidates Kotlin compilation config
marklogic-client-api/build.gradle Updates Maven publication configuration with proper property references and secure URLs
gradle.properties Removes unused describedName property

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines 164 to 165
connection = "scm:git:[email protected]:marklogic/java-client-api.git"
developerConnection = "scm:git:[email protected]:marklogic/java-client-api.git"
Copy link
Preview

Copilot AI Oct 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SCM connection URLs still use SSH format while the main URL was changed to HTTPS. Consider updating these to use HTTPS format for consistency: scm:git:https://github.com/marklogic/java-client-api.git

Suggested change
connection = "scm:git:git@github.com:marklogic/java-client-api.git"
developerConnection = "scm:git:git@github.com:marklogic/java-client-api.git"
connection = "scm:git:https://github.com/marklogic/java-client-api.git"
developerConnection = "scm:git:https://github.com/marklogic/java-client-api.git"

Copilot uses AI. Check for mistakes.

Eliminating more warnings, and forcing an error on a compiler warning.

Got rid of two systemProperty values that I don't think are needed, but we'll see what happens in the full test run.
@rjrudin rjrudin force-pushed the feature/more-changes branch from 922ee52 to d9c599a Compare October 1, 2025 17:20
@rjrudin rjrudin merged commit 30cf9ac into develop Oct 1, 2025
2 of 3 checks passed
@rjrudin rjrudin deleted the feature/more-changes branch October 1, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant