Skip to content

Conversation

rjrudin
Copy link
Contributor

@rjrudin rjrudin commented Sep 30, 2025

I think there's more to be done here - haven't chatted with Copilot yet - but this at least gets things looking very similar to our other repos that use maven-publish.

@Copilot Copilot AI review requested due to automatic review settings September 30, 2025 21:26
Copy link

github-actions bot commented Sep 30, 2025

Copyright Validation Results
Total: 7 | Passed: 1 | Failed: 0 | Skipped: 6 | at: 2025-09-30 21:31:55 UTC | commit: 8e79b0c

⏭️ Skipped (Excluded) Files

  • build.gradle
  • examples/build.gradle
  • marklogic-client-api-functionaltests/build.gradle
  • marklogic-client-api/build.gradle
  • marklogic-client-api/gradle.properties
  • test-app/build.gradle

✅ Valid Files

  • marklogic-client-api/src/test/java/com/marklogic/client/test/ProgressDataCloudAuthenticationDebugger.java

✅ All files have valid copyright headers!

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modernizes Gradle configuration across the project to align with best practices and maven-publish plugin standards. The changes modernize build script syntax, update publishing configuration, and improve consistency across modules.

  • Updates build.gradle files to use modern Gradle syntax and practices
  • Modernizes Maven publishing configuration with cleaner POM generation
  • Consolidates and standardizes configuration patterns across modules

Reviewed Changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
test-app/build.gradle Adds copyright header, properties plugin, and modernizes build directory references
marklogic-client-api/src/test/java/com/marklogic/client/test/ProgressDataCloudAuthenticationDebugger.java Fixes class name to match filename
marklogic-client-api/gradle.properties Adds Maven Central publishing configuration properties
marklogic-client-api/build.gradle Major refactoring of publishing configuration and task modernization
marklogic-client-api-functionaltests/build.gradle Removes duplicate test configuration
examples/src/main/java/com/marklogic/client/example/cookbook/README.md Removes entire documentation file
examples/build.gradle Updates copyright header and removes unnecessary plugins

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

task debugCloudAuth(type: JavaExec) {
tasks.register("debugCloudAuth", JavaExec) {
description = "Test program for manual testing of cloud-based authentication against a Progress Data Cloud instance"
mainClass = 'com.marklogic.client.test.MarkLogicCloudAuthenticationDebugger'
Copy link
Preview

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mainClass references 'MarkLogicCloudAuthenticationDebugger' but the class was renamed to 'ProgressDataCloudAuthenticationDebugger' in the same PR. This will cause the task to fail at runtime.

Suggested change
mainClass = 'com.marklogic.client.test.MarkLogicCloudAuthenticationDebugger'
mainClass = 'com.marklogic.client.test.ProgressDataCloudAuthenticationDebugger'

Copilot uses AI. Check for mistakes.

Comment on lines 140 to 144
pom {
name = "${group}:${project.name}"
description = "The MarkLogic Java Client API"
packaging = "jar"
from components.java
Copy link
Preview

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'from components.java' line should be outside the pom block. It belongs at the same level as the pom configuration, not inside it.

Suggested change
pom {
name = "${group}:${project.name}"
description = "The MarkLogic Java Client API"
packaging = "jar"
from components.java
from components.java
pom {
name = "${group}:${project.name}"
description = "The MarkLogic Java Client API"
packaging = "jar"

Copilot uses AI. Check for mistakes.

Comment on lines 163 to 164
connection = "scm:[email protected]:marklogic/java-client-api.git"
developerConnection = "scm:[email protected]:marklogic/java-client-api.git"
Copy link
Preview

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SCM connection URLs are malformed. They should be 'scm:git:[email protected]:marklogic/java-client-api.git' (with 'git:' prefix) to follow Maven SCM URL format.

Suggested change
connection = "scm:[email protected]:marklogic/java-client-api.git"
developerConnection = "scm:[email protected]:marklogic/java-client-api.git"
connection = "scm:git:git@github.com:marklogic/java-client-api.git"
developerConnection = "scm:git:git@github.com:marklogic/java-client-api.git"

Copilot uses AI. Check for mistakes.

@rjrudin rjrudin force-pushed the feature/24505-gradle-config branch from 6ec3796 to 00ab76e Compare September 30, 2025 21:29
I think there's more to be done here - haven't chatted with Copilot yet - but this at least gets things looking very similar to our other repos that use maven-publish.
@rjrudin rjrudin force-pushed the feature/24505-gradle-config branch from 00ab76e to 8e79b0c Compare September 30, 2025 21:31
@rjrudin rjrudin merged commit 8ba60db into develop Sep 30, 2025
3 checks passed
@rjrudin rjrudin deleted the feature/24505-gradle-config branch September 30, 2025 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants