-
Notifications
You must be signed in to change notification settings - Fork 74
MLE-24505 Modernizing all Gradle config #1829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Copyright Validation Results ⏭️ Skipped (Excluded) Files
✅ Valid Files
✅ All files have valid copyright headers! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR modernizes Gradle configuration across the project to align with best practices and maven-publish plugin standards. The changes modernize build script syntax, update publishing configuration, and improve consistency across modules.
- Updates build.gradle files to use modern Gradle syntax and practices
- Modernizes Maven publishing configuration with cleaner POM generation
- Consolidates and standardizes configuration patterns across modules
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
test-app/build.gradle | Adds copyright header, properties plugin, and modernizes build directory references |
marklogic-client-api/src/test/java/com/marklogic/client/test/ProgressDataCloudAuthenticationDebugger.java | Fixes class name to match filename |
marklogic-client-api/gradle.properties | Adds Maven Central publishing configuration properties |
marklogic-client-api/build.gradle | Major refactoring of publishing configuration and task modernization |
marklogic-client-api-functionaltests/build.gradle | Removes duplicate test configuration |
examples/src/main/java/com/marklogic/client/example/cookbook/README.md | Removes entire documentation file |
examples/build.gradle | Updates copyright header and removes unnecessary plugins |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
marklogic-client-api/build.gradle
Outdated
task debugCloudAuth(type: JavaExec) { | ||
tasks.register("debugCloudAuth", JavaExec) { | ||
description = "Test program for manual testing of cloud-based authentication against a Progress Data Cloud instance" | ||
mainClass = 'com.marklogic.client.test.MarkLogicCloudAuthenticationDebugger' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The mainClass references 'MarkLogicCloudAuthenticationDebugger' but the class was renamed to 'ProgressDataCloudAuthenticationDebugger' in the same PR. This will cause the task to fail at runtime.
mainClass = 'com.marklogic.client.test.MarkLogicCloudAuthenticationDebugger' | |
mainClass = 'com.marklogic.client.test.ProgressDataCloudAuthenticationDebugger' |
Copilot uses AI. Check for mistakes.
marklogic-client-api/build.gradle
Outdated
pom { | ||
name = "${group}:${project.name}" | ||
description = "The MarkLogic Java Client API" | ||
packaging = "jar" | ||
from components.java |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 'from components.java' line should be outside the pom block. It belongs at the same level as the pom configuration, not inside it.
pom { | |
name = "${group}:${project.name}" | |
description = "The MarkLogic Java Client API" | |
packaging = "jar" | |
from components.java | |
from components.java | |
pom { | |
name = "${group}:${project.name}" | |
description = "The MarkLogic Java Client API" | |
packaging = "jar" |
Copilot uses AI. Check for mistakes.
marklogic-client-api/build.gradle
Outdated
connection = "scm:[email protected]:marklogic/java-client-api.git" | ||
developerConnection = "scm:[email protected]:marklogic/java-client-api.git" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The SCM connection URLs are malformed. They should be 'scm:git:[email protected]:marklogic/java-client-api.git' (with 'git:' prefix) to follow Maven SCM URL format.
connection = "scm:[email protected]:marklogic/java-client-api.git" | |
developerConnection = "scm:[email protected]:marklogic/java-client-api.git" | |
connection = "scm:git:git@github.com:marklogic/java-client-api.git" | |
developerConnection = "scm:git:git@github.com:marklogic/java-client-api.git" |
Copilot uses AI. Check for mistakes.
6ec3796
to
00ab76e
Compare
I think there's more to be done here - haven't chatted with Copilot yet - but this at least gets things looking very similar to our other repos that use maven-publish.
00ab76e
to
8e79b0c
Compare
I think there's more to be done here - haven't chatted with Copilot yet - but this at least gets things looking very similar to our other repos that use maven-publish.