MLE-24504 Bumped Jakarta and removed javax.ws #1827
Conversation
|
Copyright Validation Results ⏭️ Skipped (Excluded) Files
✅ Valid Files
✅ All files have valid copyright headers! |
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades Jakarta dependencies and removes the unused javax.ws.rs-api dependency to prepare for version 8.0.0. The main goal is to modernize the dependency stack by moving to Jakarta 4.x APIs (which require Java 17) and eliminate unused dependencies.
Key changes:
- Updated Jakarta JAXB from 3.x to 4.x versions
- Removed javax.ws.rs-api dependency and its usage
- Updated OkHttp and other runtime dependencies to latest versions
Reviewed Changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pom.xml | Updates Jakarta and runtime dependency versions, removes javax.ws.rs-api |
| RequestParameters.java | Replaces inheritance from RequestParametersImplementation with direct HashMap implementation |
| RequestParametersImplementation.java | Completely removed as it's no longer needed |
| build.gradle | Updates Jakarta dependencies and removes javax.ws.rs-api, adds explanatory comments |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| } | ||
|
|
||
| /** | ||
| * Returns whether not any request parameters have been specified. |
There was a problem hiding this comment.
Grammar error in comment. Should be 'Returns whether or not any request parameters have been specified.' (missing 'or').
| * Returns whether not any request parameters have been specified. | |
| * Returns whether or not any request parameters have been specified. |
Copilot uses AI. Check for mistakes.
| import java.util.Set; | ||
|
|
||
| import com.marklogic.client.impl.RequestParametersImplementation; | ||
| import java.util.*; |
There was a problem hiding this comment.
[nitpick] Wildcard import should be replaced with explicit imports for better code clarity and to avoid potential naming conflicts.
| import java.util.*; | |
| import java.util.Map; | |
| import java.util.HashMap; | |
| import java.util.List; | |
| import java.util.ArrayList; | |
| import java.util.Arrays; |
Copilot uses AI. Check for mistakes.
rjrudin
force-pushed
the
feature/jakarta-bumps
branch
2 times, most recently
from
34d6393 to
2e16231
Compare
The javax.ws.rs-api dependency was only needed for a collection class that wasn't needed. Also forcing the usage of commons-lang3 as Black Duck mysteriously thinks an instance of 3.7 is being brought in as a direct dependency somehow. Also switched to latest nightly build for local testing, as Jenkins is using that too.
rjrudin
force-pushed
the
feature/jakarta-bumps
branch
from
2e16231 to
3a3bbd1
Compare
The javax.ws.rs-api dependency was only needed for a collection class that wasn't needed.
Also forcing the usage of commons-lang3 as Black Duck mysteriously thinks an instance of 3.7 is being brought in as a direct dependency somehow.