Add tall climbs filter toggle to boardsesh #299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new filter toggle that shows only climbs using holds available exclusively on the largest board size. Changes: - Add tallClimbsOnly boolean to SearchRequest type - Update filter builder with SQL logic to identify climbs extending beyond smaller size boundaries (checking edgeTop, edgeBottom, edgeLeft, edgeRight) - Add isLargestSize flag to BoardDetails to determine board size hierarchy - Add UI toggle in BasicSearchForm (visible only on largest size) - Update URL parameter serialization and analytics tracking - Fix test mocks to include new tallClimbsOnly property The filter helps users identify climbs that require the full height/width of their board configuration.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Fixed a critical bug in the tall climbs filter SQL query. The previous implementation incorrectly filtered size comparisons by dimension, causing it to miss climbs or incorrectly include them. The Bug: - Each subquery filtered sizes by the specific dimension being compared (e.g., only comparing against sizes with smaller edgeTop) - This could return no sizes in some dimensions, causing COALESCE fallbacks (0 or 999) to match almost all or no climbs incorrectly - On boards like Kilter home wall where the larger board extends downward, this failed to identify climbs using the extended bottom area The Fix: - Now queries ALL other sizes for the layout without dimension filtering - Compares climb edges against MAX/MIN of all other sizes' edges - Better COALESCE fallbacks prevent false positives when only one size exists - Correctly identifies climbs extending beyond ALL other sizes in any direction This ensures "tall climbs only" shows climbs that use holds available exclusively on the largest board size.
Fixed two issues with the tall climbs filter:
1. SQL Syntax Error:
- Removed invalid arithmetic operations in SQL template literals
- Changed COALESCE fallbacks from column arithmetic (edgeTop - 1) to
static values (999/-999)
- Fallbacks now correctly ensure no matches when only one size exists
- MAX queries use 999 so > comparisons always fail
- MIN queries use -999 so < comparisons always fail
2. Empty Results 404 Error:
- Modified page.tsx to distinguish between invalid routes and empty
filter results
- Now only returns 404 when no climbs exist AND no filters are active
- Empty filtered results display correctly instead of showing 404
- Improves UX when filters legitimately return no matches
The filter now works correctly to show climbs using holds available
exclusively on the largest board size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.