[CD-i] Fix XA audio peaking #14449
Closed
[CD-i] Fix XA audio peaking #14449
+0
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks fine, but please squash your commits, and give the squashed commit a message more in the vein of typical whatsnew entries, something along the lines of: -cdicdic: Fixed audio peaking by decoding in 32-bit and clipping to 16 later. [Vincent Halver] -cdislavehle: Simplified mouse position-update logic. [Vincent Halver] |
Vincent-Halver
force-pushed
the
master
branch
from
d75d11e to
a24f85a
Compare
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with audio peaking in Asterix's opening cutscene. It performs audio decoding in 32 bit and then clips to 16 instead of allowing overflow.
Before: Watch the opening cutscene. Notice that there is noticable audio popping.
After: No audio popping.