add some inputs and outputs as well as osd_file socket fix #13852
+24
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added "seat" input as mappable control to harddriv/racedriv. - added drive command output for gticlub hardware. - added outputs to namcos22 - made osd_socket accepts to return the same as reading with 0 bytes available, instead of returning no-error 0, which *might* be confused with end-of-stream.
cuavas
reviewed
Jun 20, 2025
| return error::NONE; | ||
| return error::FAILURE; |
There was a problem hiding this comment.
I don’t think this will compile at all – note that osd_file::error no longer exists at all, and this class no longer implements osd_file properly. It’s probably better not to change it at all unless you’re going to test that it actually still builds for WinRT partition.
There was a problem hiding this comment.
Still the behaviour should be identical to the other osd_file socket implementations, right?
It it does not build right now, the change won't hurt anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
( this is a spin-off of #13421 )