Skip to content

Conversation

@makspll
Copy link
Owner

@makspll makspll commented Oct 22, 2025

Summary

Addresses #485

Also enhances errors with this information:
image

Only applies to lua at the moment

@semanticdiff-com
Copy link

semanticdiff-com bot commented Oct 22, 2025

@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2025

🐰 Bencher Report

Branchfeat/function-call-context-location
Testbedlinux-gha
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)
Upper Boundary
nanoseconds (ns)
(Limit %)
component/access Lua📈 view plot
🚷 view threshold
3,826.50 ns
(-7.51%)Baseline: 4,137.15 ns
4,693.29 ns
(81.53%)
component/access Rhai📈 view plot
🚷 view threshold
5,559.10 ns
(-6.84%)Baseline: 5,967.17 ns
6,445.37 ns
(86.25%)
component/get Lua📈 view plot
🚷 view threshold
2,415.80 ns
(-3.33%)Baseline: 2,499.08 ns
2,829.77 ns
(85.37%)
component/get Rhai📈 view plot
🚷 view threshold
4,319.70 ns
(-3.60%)Baseline: 4,480.91 ns
4,854.07 ns
(88.99%)
conversions/Mut::from📈 view plot
🚷 view threshold
87.26 ns
(-3.00%)Baseline: 89.95 ns
106.97 ns
(81.57%)
conversions/Ref::from📈 view plot
🚷 view threshold
83.00 ns
(-5.65%)Baseline: 87.96 ns
104.55 ns
(79.38%)
conversions/ScriptValue::List📈 view plot
🚷 view threshold
379.97 ns
(+7.06%)Baseline: 354.92 ns
457.98 ns
(82.97%)
conversions/ScriptValue::Map📈 view plot
🚷 view threshold
1,020.60 ns
(-7.26%)Baseline: 1,100.55 ns
1,228.30 ns
(83.09%)
conversions/ScriptValue::Reference::from_into📈 view plot
🚷 view threshold
27.51 ns
(+1.69%)Baseline: 27.06 ns
30.50 ns
(90.20%)
conversions/Val::from_into📈 view plot
🚷 view threshold
274.82 ns
(-10.26%)Baseline: 306.24 ns
364.02 ns
(75.49%)
function/call 4 args Lua📈 view plot
🚷 view threshold
1,696.20 ns
(-9.91%)Baseline: 1,882.69 ns
2,115.69 ns
(80.17%)
function/call 4 args Rhai📈 view plot
🚷 view threshold
1,392.90 ns
(-6.89%)Baseline: 1,495.92 ns
1,631.35 ns
(85.38%)
function/call Lua📈 view plot
🚷 view threshold
281.20 ns
(+9.85%)Baseline: 255.99 ns
292.69 ns
(96.07%)
function/call Rhai📈 view plot
🚷 view threshold
425.16 ns
(-5.03%)Baseline: 447.66 ns
523.22 ns
(81.26%)
loading/empty Lua📈 view plot
🚷 view threshold
893,960.00 ns
(+54.82%)Baseline: 577,420.00 ns
1,766,978.94 ns
(50.59%)
loading/empty Rhai📈 view plot
🚷 view threshold
1,174,100.00 ns
(+44.01%)Baseline: 815,281.00 ns
1,789,500.29 ns
(65.61%)
math/vec mat ops Lua📈 view plot
🚷 view threshold
7,270.60 ns
(-9.10%)Baseline: 7,998.15 ns
9,307.05 ns
(78.12%)
math/vec mat ops Rhai📈 view plot
🚷 view threshold
6,677.60 ns
(-4.57%)Baseline: 6,997.46 ns
7,835.46 ns
(85.22%)
query/10 entities Lua📈 view plot
🚷 view threshold
21,085.00 ns
(-1.99%)Baseline: 21,513.50 ns
24,344.75 ns
(86.61%)
query/10 entities Rhai📈 view plot
🚷 view threshold
19,826.00 ns
(-6.60%)Baseline: 21,226.90 ns
23,187.15 ns
(85.50%)
query/100 entities Lua📈 view plot
🚷 view threshold
41,531.00 ns
(-4.85%)Baseline: 43,648.50 ns
47,193.18 ns
(88.00%)
query/100 entities Rhai📈 view plot
🚷 view threshold
32,438.00 ns
(-7.12%)Baseline: 34,924.20 ns
38,268.63 ns
(84.76%)
query/1000 entities Lua📈 view plot
🚷 view threshold
250,920.00 ns
(-11.77%)Baseline: 284,380.00 ns
329,006.91 ns
(76.27%)
query/1000 entities Rhai📈 view plot
🚷 view threshold
166,300.00 ns
(-4.72%)Baseline: 174,533.00 ns
196,157.06 ns
(84.78%)
reflection/10 Lua📈 view plot
🚷 view threshold
5,547.70 ns
(-11.78%)Baseline: 6,288.76 ns
7,052.76 ns
(78.66%)
reflection/10 Rhai📈 view plot
🚷 view threshold
15,158.00 ns
(-4.92%)Baseline: 15,942.30 ns
16,794.11 ns
(90.26%)
reflection/100 Lua📈 view plot
🚷 view threshold
47,034.00 ns
(-11.32%)Baseline: 53,040.50 ns
59,195.64 ns
(79.46%)
reflection/100 Rhai📈 view plot
🚷 view threshold
728,260.00 ns
(-7.50%)Baseline: 787,279.00 ns
851,576.26 ns
(85.52%)
resource/access Lua📈 view plot
🚷 view threshold
3,541.20 ns
(-4.42%)Baseline: 3,704.80 ns
4,166.48 ns
(84.99%)
resource/access Rhai📈 view plot
🚷 view threshold
5,036.20 ns
(-7.67%)Baseline: 5,454.84 ns
5,935.99 ns
(84.84%)
resource/get Lua📈 view plot
🚷 view threshold
2,093.10 ns
(-1.40%)Baseline: 2,122.85 ns
2,389.71 ns
(87.59%)
resource/get Rhai📈 view plot
🚷 view threshold
3,810.40 ns
(-4.62%)Baseline: 3,995.07 ns
4,353.72 ns
(87.52%)
🐰 View full continuous benchmarking report in Bencher

@makspll makspll changed the title feat: add location information to function calls feat: add location information to function call context Oct 24, 2025
@makspll makspll enabled auto-merge (squash) October 24, 2025 08:19
@makspll makspll merged commit aef9c2a into main Oct 24, 2025
27 of 30 checks passed
@makspll makspll deleted the feat/function-call-context-location branch October 24, 2025 09:20
@github-actions github-actions bot mentioned this pull request Oct 21, 2025
@github-actions github-actions bot mentioned this pull request Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants