Skip to content

Conversation

@Joakker
Copy link
Contributor

@Joakker Joakker commented Feb 16, 2025

Adds macros for the TypedThrough and IntoScript traits. Let me know if there are other traits with reasonable default implementations

@Joakker Joakker changed the title Add derive macros feat: Add derive macros Feb 16, 2025
@makspll
Copy link
Owner

makspll commented Feb 17, 2025

Looks good! Could you have a look at the clippy failures?

@Joakker
Copy link
Contributor Author

Joakker commented Feb 17, 2025

Will do

@Joakker
Copy link
Contributor Author

Joakker commented Feb 19, 2025

I think that should do it. The failing tests have to do with Ladfiles, which I didn't touch

@makspll
Copy link
Owner

makspll commented Feb 19, 2025

Yup, thats fine, thank you!

@makspll makspll changed the title feat: Add derive macros feat: Add TypedThrough and IntoScript derive macros Feb 19, 2025
@makspll makspll added the needs documentation For features or changes which still need changes in the book label Feb 19, 2025
@makspll makspll merged commit 5f0a452 into makspll:main Feb 19, 2025
14 of 16 checks passed
@makspll makspll removed the needs documentation For features or changes which still need changes in the book label Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants