Skip to content

Make DirectoryResolver Response Cacheable #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 16, 2019
Merged

Make DirectoryResolver Response Cacheable #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bba33b0
Hard code cache header to test on cloud
tjwiebell Dec 10, 2019
92a35e7
Bump up value to year, appease Lighthouse
tjwiebell Dec 10, 2019
84e92d5
Add comment and test
tjwiebell Dec 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Resolver/Directory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,8 @@ public function resolve($definition)

$response->setStream(fopen($path, 'r'));
$response->getHeaders()->addHeader(new ContentType($mimeType));
// Enforce best practice and make sure static assets are cacheable
$response->getHeaders()->addHeaderLine('Cache-Control', 'max-age=31557600');
}

return $response;
Expand Down
1 change: 1 addition & 0 deletions test/Resolver/DirectoryTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ public function testResolve(): void
verify($result)->is()->instanceOf(Response::class);
verify($result->getStatusCode())->is()->sameAs(200);
verify($result->getHeaders()->get('Content-Type')->getFieldValue())->is()->sameAs('text/plain');
verify($result->getHeaders()->get('Cache-Control')->getFieldValue())->is()->sameAs('max-age=31557600');
verify($result->getBody())->is()->equalToFile(__DIR__ . '/_data/sample.txt');
}

Expand Down