Date Test additional fix #923
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h PHP date and one form Magento Core. DateTest.php passed
Author
|
@mage2-team This fix didn't pass DateTest throught but its DateTest fix itself so it would be great if you merge it as it resolve issue with asset test fail even if the date is correct (except AM/PM stuff). |
…ll as full Integration test
Closed
Contributor
|
This change breaks test on Travis CI which is green now: https://travis-ci.org/magento/magento2/builds If fix introduced by #913 is incomplete for your case, change test in such a way that it works for your local environment and Travis CI at the same time. |
|
Closing the ticket due to inactivity from author (2 weeks). @snky1987 If you still want to fix the pull request, let us know or feel free to open a newer pull request. |
magento-team
pushed a commit
that referenced
this pull request
Mar 14, 2017
[EngCom] Public Pull Requests
VitaliyBoyko
pushed a commit
to VitaliyBoyko/magento2
that referenced
this pull request
Jun 22, 2018
…siness_logic [*] 898 : moved precentation logic to new module;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DateTest.php still failed because of difference between capital and lowercase AM/PM
One generated by Magento core was lowercase and date() function returned capital PM (or AM).
After test 100% ok now in my case.