Additional check for existance of install.log to prevent warning in console #916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 6, 2015 09:57
…nstallation error due to not created log file (reproduced several times by Trying Install Again without refresh installation process page after other error)
…ting anymore (most probably have been fixed and page wasn't refreshed)
Author
|
With new pull request added simple solution for #919 issue. |
magento-team
pushed a commit
that referenced
this pull request
Dec 12, 2017
- Merge Pull Request magento-engcom/magento2ce#916 from RomaKis/magento2:8862 - Merged commits: 1. 1ef70f0
magento-team
pushed a commit
that referenced
this pull request
Dec 12, 2017
magento-team
pushed a commit
that referenced
this pull request
Dec 12, 2017
EngCom] Public Pull Requests - 2.2-develop - MAGETWO-85520: Remove @escapenotverified from documentation #12639 - MAGETWO-85317: 12526: Currency change, Bank Transfer but checkout page shows "Your credit card will be charged for" #993 - MAGETWO-85298: 8011: Strip Tags from attribute. #968 - MAGETWO-85294: 12535: Product change sku via repository. #984 - MAGETWO-85274: Update CrontabManager.php #12610 - MAGETWO-84994: 8862: Can't emptying values by magento 2 api #916
magento-engcom-team
added a commit
that referenced
this pull request
Sep 10, 2019
- Merge Pull Request magento/graphql-ce#916 from pmclain/graphql-ce:issue/875 - Merged commits: 1. 28596de
magento-engcom-team
pushed a commit
that referenced
this pull request
Sep 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I got an error mentioned in #904 comment and clicked Try Again I received error in console:
Warning: fopen(foo\bar\Local\Temp\install.log): failed to open stream: No such file or directory in foo\bar\Projects\magento2\setup\module\Magento\Setup\src\Model\WebLogger.php on line 59
Warning: fseek() expects parameter 1 to be resource, boolean given in foo\bar\magento2\setup\module\Magento\Setup\src\Model\WebLogger.php on line 148
Warning: fgets() expects parameter 1 to be resource, boolean given in foo\bar\magento2\setup\module\Magento\Setup\src\Model\WebLogger.php on line 150
Warning: fclose() expects parameter 1 to be resource, boolean given in foo\bar\magento2\setup\module\Magento\Setup\src\Model\WebLogger.php on line 69
Warning: fopen(foo\bar\Local\Temp\install.log): failed to open stream: No such file or directory in foo\bar\magento2\setup\module\Magento\Setup\src\Model\WebLogger.php on line 59
Warning: fseek() expects parameter 1 to be resource, boolean given in foo\bar\magento2\setup\module\Magento\Setup\src\Model\WebLogger.php on line 148
Warning: fgets() expects parameter 1 to be resource, boolean given in foo\bar\magento2\setup\module\Magento\Setup\src\Model\WebLogger.php on line 150
Warning: fclose() expects parameter 1 to be resource, boolean given in foo\bar\magento2\setup\module\Magento\Setup\src\Model\WebLogger.php on line 69
{"progress":"0","success":true,"console":[]}
It may be just some kind of silly error due to progress process run before install.log file is created. To prevent it I added simple is_resource check for fclose function and also on open() function to create file if doesn't exists.
I didn't have this issue during next 10 installation processes after this fix.