Small cleanup refactoring #903
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The integration test failure is because of the issue fixed in #913, not because of this PR. |
Contributor
Contributor
|
@Vinai, could you remove the last empty commit from this pull request? To re-run tests you just need to click "Restart Job" button on job page (look at https://travis-ci.org/magento/magento2/jobs/45948063 for example). We would like to prevent empty commits in our development history. The other way to run tests on updated code is syncing your branch with latest changes from upstream repository. For more information see - https://help.github.com/articles/syncing-a-fork/ |
* Fix typo in method name * Change interpret method return value to conform with Layout\ReaderInterface
Contributor
Author
|
Sure, I updated the PR with a squashed commit. |
Contributor
|
CR: passed |
vpelipenko
added a commit
that referenced
this pull request
Jan 8, 2015
Small cleanup refactoring (MAGETWO-32404)
magento-team
pushed a commit
that referenced
this pull request
Mar 14, 2017
[Epam] Extend functional test sprint 3 - MTO-102: [Test] Captcha on register customer - MTO-136: [Test] [Test] Captcha on Contact Us form - MTO-144: [Test] Captcha and lockout for Storefront login page - MTO-121: [Variation] Move Anchored Category with Products (cron is ON, "Update on Save") - MTO-134: [Variation] Add Simple Product with required Custom Options to Cart
okorshenko
pushed a commit
that referenced
this pull request
Nov 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR against the develop branch replaces #750.
It contains the following refactorings: