Skip to content

Conversation

josephmcdermott
Copy link
Contributor

@josephmcdermott josephmcdermott commented Mar 16, 2017

Description

Related to #8654

Current Magento2 code only includes the Reply-To email address, whereas it is useful to also have the Reply-To name, which will always be included due to the Contact Controller validation.

Fixed Issues (if relevant)

N/A

Manual testing scenarios

Send an email using Contact Form and check headers include both Email Address and Name of the Contact who sent the email.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • [-] All new or changed code is covered with unit/integration tests (if applicable)
  • [-] All automated tests passed successfully (all builds on Travis CI are green)

@okorshenko okorshenko self-assigned this Mar 16, 2017
@okorshenko okorshenko added this to the March 2017 milestone Mar 16, 2017
@okorshenko okorshenko modified the milestones: March 2017, April 2017 Apr 2, 2017
@okorshenko
Copy link
Contributor

okorshenko commented Apr 10, 2017

@josephmcdermott thank you for your contribution. The code in current state does not work properly. We did some fixes based on your PR and doing testing right now.
Thank you

@magento-team magento-team merged commit 982b662 into magento:develop Apr 12, 2017
@okorshenko
Copy link
Contributor

@josephmcdermott thank you for your contribution! Your pull request has been successfully merged to develop branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants