Use page result instead of rendering layout directly in controllers #8419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@schmengler Thank you for your contribution. Could you please fix broken unit tests so that we can accept this Pull Request. |
Contributor
Author
|
I did it, tests pass now, but the Travis job had a timeout, you need to re-run it |
Contributor
|
@schmengler thank you. I will take a look at Travis timeout issue. |
Contributor
|
Issue with Travis timeout is fixed. We changed the balance of integration tests |
okorshenko
approved these changes
Feb 7, 2017
Contributor
|
@schmengler this PR merge to develop branch. Thank you for cleaning up Magento code! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just changed the controllers that did nothing but rendering the layout. There is no reason to keep the old way there.