Skip to content

Update attributes.phtml #8397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update attributes.phtml #8397

wants to merge 1 commit into from

Conversation

@springimport
Copy link

@springimport springimport commented Feb 2, 2017 •
edited by okorshenko
Loading

Fix ";"

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Feb 2, 2017 •
edited
Loading

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@okorshenko okorshenko self-assigned this Feb 2, 2017
@okorshenko okorshenko self-requested a review February 2, 2017 21:54
@okorshenko
Copy link
Contributor

okorshenko commented Feb 2, 2017

Hi @springimport

Could you please sign Contributor License Agreement so that we can process this Pull Request?
Thank you for your contribution!

@okorshenko
Copy link
Contributor

okorshenko commented Feb 3, 2017

Hi @springimport
Could you please sign Contributor License Agreement so that we can process this Pull Request?

@okorshenko
Copy link
Contributor

okorshenko commented Feb 4, 2017

Hi @springimport
I hope you are doing great!
Could you please sign Contributor License Agreement so that we can process this Pull Request?
This PR is super simple, but we can't accept it without CLA.
Thank you

@okorshenko
Copy link
Contributor

okorshenko commented Feb 7, 2017

Hi @springimport
Could you please sign Contributor License Agreement so that we can process this Pull Request?

@okorshenko
Copy link
Contributor

okorshenko commented Feb 8, 2017

@springimport we fixed this issue in magento code. Thank you for this PR.

@okorshenko okorshenko closed this Feb 8, 2017
@okorshenko okorshenko added this to the February 2017 milestone Feb 11, 2017
@vrann vrann added the simple label Mar 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@okorshenko okorshenko okorshenko approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@okorshenko okorshenko

Labels

Component: Catalog improvement Progress: accept

Projects

None yet

Milestone

February 2017

Development

Successfully merging this pull request may close these issues.

4 participants

@springimport @magento-cicd2 @okorshenko @vrann