Magento_Bundle fails with successive programatically calls to add to cart

[kassner]

FIX: Magento\Bundle\Model\Product\Type::_prepareProduct cannot be called twice
with different product selections, throws fatal error:

PHP Fatal error: Uncaught Error: Call to a member function getPosition() on
null in /var/www/html/vendor/magento/module-bundle/Model/Product/Type.php:937

[vrann]

@kassner unfortunately, we don't process PRs to 2.1 branch at the moment. Please re-create it against develop branch.

[kassner]

@vrann can you reopen? GitHub allows to rebase the PR from the interface.

[vrann]

@kassner can you please merge with the latest develop?

[kassner]

@vrann done.

[vrann]

@kassner trying to reproduce the issue, can you please provide steps?

[kassner]

@vrann Using Magento's sample data, you can go simulate with this controller:

<?php

namespace My\Test\Controller;

class Index extends \Magento\Framework\App\Action\Action
{

    public function __construct(
        \Magento\Framework\App\Action\Context $context,
        \Magento\Catalog\Model\ProductRepository $productRepository,
        \Magento\Quote\Model\QuoteFactory $quoteFactory
    ) {
        parent::__construct($context);
        $this->productRepository = $productRepository;
        $this->quoteFactory = $quoteFactory;
    }

    protected function addAndCalculate($product, $request)
    {
        $quote = $this->quoteFactory->create();
        $quote->addProduct($product, $request);
        $quote->getShippingAddress(); // Needed to go around another bug
        $quote->setTotalsCollectedFlag(false);
        $quote->collectTotals();

        return $quote->getGrandTotal();
    }

    public function execute()
    {
        $p1 = $this->productRepository->get('24-WG080');

        var_dump($this->addAndCalculate($p1, new \Magento\Framework\DataObject([
            'product' => $p1->getId(),
            'qty' => 1,
            'bundle_option' => [
                1 => 1,
                2 => 4,
                3 => 5,
                4 => 8,
            ],
            'bundle_option_qty' => [
                1 => 1,
                2 => 1,
                3 => 1,
                4 => 1,
            ],
        ])));

        $p2 = $this->productRepository->get('24-WG080');

        var_dump($this->addAndCalculate($p2, new \Magento\Framework\DataObject([
            'product' => $p2->getId(),
            'qty' => 1,
            'bundle_option' => [
                1 => 3,
                2 => 4,
                3 => 7,
                4 => 8,
            ],
            'bundle_option_qty' => [
                1 => 1,
                2 => 1,
                3 => 1,
                4 => 1,
            ],
        ])));
    }

}

You might need to adjust the bundle_option IDs to match your database (I have a clean one).

[okorshenko]

Hi @kassner
Thank you for your contribution. After several internal discussions, we decided that adding a new flag to the Selection collection is not the best approach. Also, it is clear that having the flag in the Option collection is a legacy code that must be refactored but in a different way (without moving this state flag to another object). This logic must be refactored in a way when option collection and selections won't depend on each other.
Back to your sample code:

$p1 = $this->productRepository->get('24-WG080');
$p2 = $this->productRepository->get('24-WG080');

it is clear that
$p1 === $p2
Since method qoute->addProduct modifis the object state, we can not perform this action in one request.
Here you have few options:

1. refactor the code in the suggested way (long way)
2. get product from repository using argument $forceReload = true (quick solution, but may affect performance if you iterate a lot of products)
3. unset option collection before adding to the cart (dirty way)
   $product->unsetData('_cache_instance_options_collection');

Closing this Pull Request for now. Please, let us know if you would like to work on this refactoring so that we can discuss implementation details and design.