Skip to content

Use backend model also for default config values #7742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 19, 2017
Merged

Use backend model also for default config values #7742

merged 5 commits into from
Jul 19, 2017

Conversation

@kweij
Copy link
Contributor

@kweij kweij commented Dec 9, 2016 •
edited by okorshenko
Loading

This causes the afterLoad() method to be invoked, also for default configuration values from config.xml

Fixes issue #7741

@kweij
Use backend model also for default config values
f2f1d36 
This causes the ```afterLoad()``` method to be invoked, also for default configuration values from ```config.xml```
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Dec 9, 2016 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@kweij kweij mentioned this pull request Dec 9, 2016
Closed
@antonkril
Copy link
Contributor

antonkril commented Jan 10, 2017

@kweij please fix failing tests.

@ishakhsuvarov
Copy link
Contributor

ishakhsuvarov commented Mar 23, 2017

Hi @kweij
I'm closing this PR for now due to inactivity. Please reopen if you would like to continue work on it.
Thank you.

@kweij
Copy link
Contributor Author

kweij commented Jun 13, 2017 •
edited
Loading

Where can I find the failed test results? I'd like to continue work on this.

Found it!

@ishakhsuvarov ishakhsuvarov reopened this Jun 13, 2017
@ishakhsuvarov
Copy link
Contributor

ishakhsuvarov commented Jun 13, 2017

@kweij I've reopened the PR. Plese sync your branch with the latest develop and resolve conflicts. You will see test results by following Travis CI details link.

kweij and others added 4 commits June 29, 2017 11:00
@kweij
Merge branch 'develop' into patch-2
38f1343
@kweij
Use backend model also for default config values
3d01997 
This causes the ```afterLoad()``` method to be invoked, also for default configuration values from ```config.xml```
Merge branch 'patch-2' of https://github.com/kweij/magento2 into patch-2
94b9511 
Conflicts resolved:
	app/code/Magento/Config/Block/System/Config/Form.php
Update test to match expected results
e8981b8
@kweij
Copy link
Contributor Author

kweij commented Jun 30, 2017

@antonkril I can't get the tests to run without failure. I had to change the unit test to change the expected result (this sounds horrible, but it just wasn't correct) - but now the integration test fails and my understanding of these tests is insufficient to deal with this issue. Any help would be appreciated.

@ishakhsuvarov
Copy link
Contributor

ishakhsuvarov commented Jun 30, 2017

Hi @kweij
I will look into the test failures and let you know if I find anything useful.

@kweij kweij mentioned this pull request Jun 30, 2017
Closed
@okorshenko okorshenko self-assigned this Jul 17, 2017
@okorshenko okorshenko added this to the July 2017 milestone Jul 17, 2017
@magento-team magento-team merged commit e8981b8 into magento:develop Jul 19, 2017
magento-team pushed a commit that referenced this pull request Jul 19, 2017
MAGETWO-70797: Use backend model also for default config values #7742
59341a0 
 - fixed integration tests
magento-team pushed a commit that referenced this pull request Jul 19, 2017
MAGETWO-70797: Use backend model also for default config values #7742
ddb09f9
@korostii korostii mentioned this pull request Aug 10, 2017
Closed
@kweij kweij deleted the patch-2 branch October 9, 2017 11:07
magento-devops-reposync-svc pushed a commit that referenced this pull request Aug 10, 2022
@sidolov
Merge pull request #7742 from magento-atwix-pyrrans/AC-3643
4048f18 
[Pyrrans] AC-3643 Port fixes for PHP8.1 compatibility issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@okorshenko okorshenko

Labels

Progress: accept

Projects

None yet

Milestone

July 2017

Development

Successfully merging this pull request may close these issues.

6 participants

@kweij @magento-cicd2 @antonkril @ishakhsuvarov @magento-team @okorshenko