Fix Swagger output - update operation parameter "name" when parameter "in" is "body" #7432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rameter "in" is "body" This was previously being output as a string "$body" which appears to have been a workaround for a now-fixed swagger-codegen bug (#630). The convention appears to be name "body" when using in "body" elsewhere. Other parameters in Magento's swagger file are not pre-fixed with a dollar sign. Removing this would prevent variable variable assignments when using php-based Swagger / Open API code generators like janephp/openapi.
Contributor
|
|
careys7
changed the title
Member
Author
|
Closed in favour of #7446 which includes user-friendly body-class naming if using a generated client. |
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Apr 12, 2022
…develop AC-2218: Fixed problem when Magento updates from 2.2 to 2.3, next 2.4.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was previously being output as a string "$body" which appears to have been a workaround for a now-fixed swagger-codegen bug PR 630. The convention appears to be name "body" when using in "body" elsewhere.
Other parameters in Magento's swagger file are not prefixed with a dollar sign. Removing this would also prevent variable variable assignments when using php-based Swagger / Open API code generators like janephp/openapi.