Save shipping discount in $total #5858
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shipping discount should be accounted in the \Magento\Tax\Model\Sales\Total\Quote\CommonTaxCollector::getShippingDataObject:
if ($total->getShippingDiscountAmount()) {
if ($useBaseCurrency) {
$itemDataObject->setDiscountAmount($total->getBaseShippingDiscountAmount());
} else {
$itemDataObject->setDiscountAmount($total->getShippingDiscountAmount());
}
}
but is not initialized in $total.
vkorotun
added
Component: Shipping
bug report
Component: Tax
bugfix
and removed
Component: Shipping
bug report
labels
|
Can we please prioritize this PR please? My team also needs this fix. |
Contributor
|
@flancer64 @ntekka Pull Request has now been merged into the |
magento-engcom-team
pushed a commit
that referenced
this pull request
Jul 9, 2020
[TSG-CSL3] For 2.4|2.4|1.2 (pr33)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shipping discount should be accounted in the \Magento\Tax\Model\Sales\Total\Quote\CommonTaxCollector::getShippingDataObject:
but is not initialized in $total. Shipping tax (and tax for whole order) is wrong when shipping discount is used in sales rules cause shipping amount is not decreased to discount amount before tax calculation.
#4585