Skip to content

GraphQL cannot add product with customizable option to cart #37599 #37652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

shomiadarshlt
Copy link
Contributor

@shomiadarshlt shomiadarshlt commented Jun 22, 2023

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes GraphQL cannot add product with customizable option to cart #37599

Manual testing scenarios (*)

  • Go to admin panel > Catalog > Products

  • Create a simple product (Joust Duffle bag)

  • Create a custom option for Joust Duffle Bag

  • Create a empty cart using graphql
    mutation {
    createEmptyCart
    }

  • Get product options information
    {
    products(filter: {sku: {eq: "24-MB01"}}) {
    items {
    uid
    name
    sku
    __typename
    ... on CustomizableProductInterface {
    options {
    title
    required
    sort_order
    uid
    ... on CustomizableFieldOption {
    textField: value {
    sku
    price
    }
    }
    ... on CustomizableDropDownOption {
    dropDown: value {
    sku
    price
    }
    }
    }
    }
    }
    }
    }

  • Add product to cart using custom option
    mutation {
    addProductsToCart(
    cartId: "62zbf0JBpn9s3U7C2iIze2sWidmMU6Es"
    cartItems: [
    {
    quantity: 1
    sku: "24-MB01"
    entered_options: [{
    uid: "Y3VzdG9tLW9wdGlvbi8y"
    value: "test"
    }]
    }
    ]
    ) {
    cart {
    items {
    product {
    name
    sku
    }
    ... on SimpleCartItem {
    customizable_options {
    customizable_option_uid
    label
    values {
    customizable_option_value_uid
    value
    }
    }
    }
    quantity
    }
    }
    user_errors {
    code
    message
    }
    }
    }

  • The response will have the array customizable_options fetched with data
    {
    "data": {
    "addProductsToCart": {
    "cart": {
    "items": [
    {
    "product": {
    "name": "Joust Duffle bag",
    "sku": "24-MB01"
    },
    "customizable_options": [
    {
    "customizable_option_uid": "Y3VzdG9tLW9wdGlvbi8y",
    "label": "test",
    "values": [
    {
    "customizable_option_value_uid": "Y3VzdG9tLW9wdGlvbi8y",
    "value": "test"
    }
    ]
    }
    ],
    "quantity": 1
    }
    ]
    },
    "user_errors": []
    }
    }
    }

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jun 22, 2023

Hi @shomiadarshlt. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@shomiadarshlt
Copy link
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@shomiadarshlt
Copy link
Contributor Author

https://github.com/magento run all tests

@shomiadarshlt
Copy link
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@engcom-Charlie engcom-Charlie added the Priority: P3 May be fixed according to the position in the backlog. label Jun 27, 2023
@m2-community-project m2-community-project bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S1 Affects critical data or functionality and forces users to employ a workaround. labels Jun 30, 2023
@shomiadarshlt
Copy link
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@andrewbess
Copy link
Contributor

This PR already merged and shouldn't have pending review status

@andrewbess andrewbess removed Progress: pending review Priority: P3 May be fixed according to the position in the backlog. labels Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Partner: EY partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S1 Affects critical data or functionality and forces users to employ a workaround.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GraphQL cannot add product with customizable option to cart
5 participants