Skip to content

#32910 fix rewriting category product URL for the one store group #35053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
May 3, 2023
Merged

#32910 fix rewriting category product URL for the one store group #35053

merged 25 commits into from
May 3, 2023

Conversation

korovitskyi
Copy link
Collaborator

Description (*)

Fixed adding category to product in store view scope to generate all url rewrites

Fixed Issues (if relevant)

  1. Fixes Adding category to product in store view scope does not generate all url rewrites #32910

Manual testing scenarios (*)

  1. Create 2 store views
  2. Create category with anchor enabled (and in 2.4.2 make sure category/product url generation is enabled)
  3. Add new product without category
  4. Open product edit in storeview scope
  5. Add product to category and save

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Feb 2, 2022

Hi @korovitskyi. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-github-services m2-github-services added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Feb 2, 2022
@m2-community-project m2-community-project bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Feb 2, 2022
@korovitskyi
Copy link
Collaborator Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

andrewbess
andrewbess requested changes Feb 4, 2022
View reviewed changes
Copy link
Contributor

@andrewbess andrewbess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @korovitskyi
Thank you for your contribution.
Could you please fix failed tests (you can ask me about it)?
Thank you in advance.

@korovitskyi korovitskyi force-pushed the 32910-fix-addinig-url-rewrite-for-one-store-group branch from 95546ae to 2610276 Compare February 14, 2022 11:54
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@korovitskyi korovitskyi force-pushed the 32910-fix-addinig-url-rewrite-for-one-store-group branch 2 times, most recently from 1a23ab7 to c6fd7a5 Compare February 15, 2022 15:02
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@korovitskyi korovitskyi force-pushed the 32910-fix-addinig-url-rewrite-for-one-store-group branch from c6fd7a5 to e33a4b2 Compare February 16, 2022 14:51
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@korovitskyi korovitskyi force-pushed the 32910-fix-addinig-url-rewrite-for-one-store-group branch from e33a4b2 to 5f8ba80 Compare February 17, 2022 12:23
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

1 similar comment
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@korovitskyi korovitskyi force-pushed the 32910-fix-addinig-url-rewrite-for-one-store-group branch from f47181b to e0a36e8 Compare February 19, 2022 10:13
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@korovitskyi korovitskyi force-pushed the 32910-fix-addinig-url-rewrite-for-one-store-group branch from e0a36e8 to a986a5d Compare February 21, 2022 09:06
@korovitskyi
Copy link
Collaborator Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Lima
Merge branch '2.4-develop' of https://github.com/magento/magento2 int…
a2d4b14 
…o 32910-fix-addinig-url-rewrite-for-one-store-group
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@hostep
Copy link
Contributor

hostep commented Jan 5, 2023

@engcom-Echo: the changes you did to dev/tests/integration/testsuite/Magento/Quote/Model/ShippingMethodManagementTest.php don't seem to have anything to do with generating url rewrites. Why did you change that file in scope of this PR? Shouldn't it go into it's own PR?

@engcom-Echo
Copy link
Contributor

engcom-Echo commented Jan 5, 2023 •
edited
Loading

@hostep there is test failure although it is not related to PR but to process PR we need to fix such failures.In this case we have only rearrange the test so that previous test do not cause any failure in next test.

@engcom-Echo
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@hostep
Copy link
Contributor

hostep commented Jan 5, 2023

there is test failure although it is not related to PR but to process PR we need to fix such failures.In this case we have only rearrange the test so that previous test do not cause any failure in next test.

So this will need to be fixed in every single new PR here on github?? Because this PR here will probably take a few days until merged?

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

1 similar comment
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Echo
Copy link
Contributor

there is test failure although it is not related to PR but to process PR we need to fix such failures.In this case we have only rearrange the test so that previous test do not cause any failure in next test.

So this will need to be fixed in every single new PR here on github?? Because this PR here will probably take a few days until merged?

Yes this is the process. If there are any test failure on PR we need to fix those failure before merging. Or get an approval for tests failures if required to merge such PR.

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

2 similar comments
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Echo
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

1 similar comment
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Echo
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

4 similar comments
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@hostep hostep mentioned this pull request Jan 12, 2023
Closed
5 tasks
@engcom-Echo
Copy link
Contributor

Functional Tests CE Failures are different on last two run and an issue with the currency converter server outage.
Run1
image

Run2
image

Also Functional Test B2B and EE are related to issue with the currency converter server outage.

Hence Moving to Merge In Progress

@magento-devops-reposync-svc magento-devops-reposync-svc merged commit 0a88775 into magento:2.4-develop May 3, 2023
@mveldhuizen mveldhuizen mentioned this pull request Aug 22, 2024
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewbess andrewbess andrewbess requested changes

@ishakhsuvarov ishakhsuvarov ishakhsuvarov approved these changes

Assignees

@ishakhsuvarov ishakhsuvarov

@andrewbess andrewbess

@engcom-Charlie engcom-Charlie

@engcom-Echo engcom-Echo

@engcom-Lima engcom-Lima

Labels
Component: CatalogUrlRewrite Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Release Line: 2.4
Projects
Pull Requests Dashboard
Status: Recently Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding category to product in store view scope does not generate all url rewrites