fix double reference to PERMISSIONS_DIR class constant #3474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelbalparda
referenced
this pull request
in nexcess/magento2
Feb 22, 2016
hshar7
added
the
Issue: Ready for Work
|
MAGETWO-50235 Internal ticket created to process this PR |
|
Magento 2 does not manage file permissions anymore. @ryebell Thank you for the contribution anyway. |
paliarush
removed
the
Issue: Ready for Work
magento-engcom-team
pushed a commit
that referenced
this pull request
Nov 26, 2018
[2.3-develop] Bug Fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed when switching to production mode that the file permissions were set to 750, rather than 640 as common in most other areas. After updating this line it looks like the proper permissions are applied when switching modes via bin/magento deploy:mode:set .