validateCategory() should check for valid return types of validate() function #3437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng and fixing unit tests
Contributor
Author
|
Accompanying issue: #3438. |
Contributor
|
Hi Stefan, Thanks for contributing! Thanks, |
katmoon
added
the
Issue: Ready for Work
Contributor
|
Hi Stefan, The issue #3438 has been fixed by updating the unit test and relevant PHPdocs, so this PR is rejected. Thanks, |
magento-engcom-team
pushed a commit
that referenced
this pull request
Nov 14, 2018
[TSG] MFTF for 2.3 (pr8) (2.3.1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The validate() function returns true or an array. If not true, it assumes an array. But e.g. in some unit tests (Catalog/Test/Unit/Model/CategoryRepositoryTest.php) the validate() output is set to false. That means a false is inserted in the foreach() call, which results in a warning and could break the tests.