Fixed flaky integration tests #33771

andrewbess · 2021-08-12T12:08:55Z

Description (*)

This pull request provides the fix for flaky integration tests.

Related Pull Requests

https://github.com/magento/partners-magento2ee/pull/591

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

m2-assistant · 2021-08-12T12:08:57Z

Hi @andrewbess. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me platform-health instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

andrewbess · 2021-08-12T12:09:19Z

@magento run Integration Tests

magento-automated-testing · 2021-08-12T12:09:23Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

andrewbess · 2021-08-12T14:04:31Z

@magento run Integration Tests

magento-automated-testing · 2021-08-12T14:04:35Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

andrewbess · 2021-08-12T16:10:01Z

@magento run Integration Tests

magento-automated-testing · 2021-08-12T16:10:08Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

andrewbess · 2021-08-13T20:25:25Z

@magento run Integration Tests

magento-automated-testing · 2021-08-13T20:25:29Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

andrewbess · 2021-08-16T06:39:08Z

@magento run Integration Tests

magento-automated-testing · 2021-08-16T06:39:13Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

andrewbess · 2021-08-16T11:17:46Z

@magento run Database Compare, Semantic Version Checker, WebAPI Tests, Unit Tests, Static Tests, Magento Health Index, Functional Tests CE, Functional Tests EE, Functional Tests B2B, Sample Data Tests EE, Sample Data Tests CE, Sample Data Tests B2B

magento-automated-testing · 2021-08-16T11:17:51Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

sivaschenko · 2021-08-16T17:36:39Z

...egration/testsuite/Magento/CatalogImportExport/Model/AbstractProductExportImportTestCase.php

            ]);
            $itemsPerPageProperty->setAccessible(true);
-            $itemsPerPageProperty->setValue($exportProduct, 1);
+            $itemsPerPageProperty->setValue($exportProduct, 2);


@andrewbess can you please add a description to the pull request. Why 2?

andrewbess · 2021-08-16T20:36:08Z

@magento run Integration Tests

magento-automated-testing · 2021-08-16T20:36:12Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

fascinosum · 2021-08-16T23:23:27Z

@magento run Integration Tests

magento-automated-testing · 2021-08-16T23:23:35Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

andrewbess · 2021-08-17T02:51:09Z

@magento run Database Compare, Semantic Version Checker, WebAPI Tests, Unit Tests, Static Tests, Magento Health Index, Functional Tests CE, Functional Tests EE, Functional Tests B2B, Sample Data Tests EE, Sample Data Tests CE, Sample Data Tests B2B

magento-automated-testing · 2021-08-17T02:51:17Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

andrewbess · 2021-08-17T03:15:04Z

@magento run all tests

magento-automated-testing · 2021-08-17T03:15:11Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2021-08-17T04:40:10Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2021-08-17T05:03:55Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2021-08-17T05:40:10Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2021-08-17T05:40:13Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2021-08-17T07:20:01Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2021-08-17T07:36:33Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2021-08-17T10:32:50Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

m2-assistant · 2021-08-17T10:38:53Z

Hi @andrewbess, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Aug 12, 2021

andrewbess force-pushed the bugfix/fixes-for-failed-integration-tests branch from 0ff8297 to 2eab7fe Compare August 16, 2021 06:37

sivaschenko reviewed Aug 16, 2021

View reviewed changes

m2-community-project bot assigned sivaschenko Aug 16, 2021

m2-community-project bot added the Progress: review label Aug 16, 2021

Fixed failed integration tests

03b3d28

andrewbess force-pushed the bugfix/fixes-for-failed-integration-tests branch from 2eab7fe to 03b3d28 Compare August 16, 2021 20:34

sivaschenko approved these changes Aug 17, 2021

View reviewed changes

m2-community-project bot added Progress: ready for testing and removed Progress: review labels Aug 17, 2021

eduard13 approved these changes Aug 17, 2021

View reviewed changes

m2-community-project bot assigned eduard13 Aug 17, 2021

eduard13 added the Award: special achievement label Aug 17, 2021

andrewbess changed the title ~~[TEST DO NOT TOUCH] Checked failed changes in commit scope~~ Fixed flaky integration tests Aug 17, 2021

andrewbess merged commit ffdb308 into magento:platform-health Aug 17, 2021

Fixed flaky integration tests #33771

Fixed flaky integration tests #33771

Uh oh!

Conversation

andrewbess commented Aug 12, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Related Pull Requests

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Aug 12, 2021

Uh oh!

andrewbess commented Aug 12, 2021

Uh oh!

magento-automated-testing bot commented Aug 12, 2021

Uh oh!

andrewbess commented Aug 12, 2021

Uh oh!

magento-automated-testing bot commented Aug 12, 2021

Uh oh!

andrewbess commented Aug 12, 2021

Uh oh!

magento-automated-testing bot commented Aug 12, 2021

Uh oh!

andrewbess commented Aug 13, 2021

Uh oh!

magento-automated-testing bot commented Aug 13, 2021

Uh oh!

andrewbess commented Aug 16, 2021

Uh oh!

magento-automated-testing bot commented Aug 16, 2021

Uh oh!

andrewbess commented Aug 16, 2021

Uh oh!

magento-automated-testing bot commented Aug 16, 2021

Uh oh!

sivaschenko Aug 16, 2021

Choose a reason for hiding this comment

Uh oh!

andrewbess commented Aug 16, 2021

Uh oh!

magento-automated-testing bot commented Aug 16, 2021

Uh oh!

fascinosum commented Aug 16, 2021

Uh oh!

magento-automated-testing bot commented Aug 16, 2021

Uh oh!

andrewbess commented Aug 17, 2021

Uh oh!

magento-automated-testing bot commented Aug 17, 2021

Uh oh!

andrewbess commented Aug 17, 2021

Uh oh!

magento-automated-testing bot commented Aug 17, 2021

Uh oh!

magento-automated-testing bot commented Aug 17, 2021

Uh oh!

magento-automated-testing bot commented Aug 17, 2021

Uh oh!

magento-automated-testing bot commented Aug 17, 2021

Uh oh!

magento-automated-testing bot commented Aug 17, 2021

Uh oh!

magento-automated-testing bot commented Aug 17, 2021

Uh oh!

magento-automated-testing bot commented Aug 17, 2021

Uh oh!

magento-automated-testing bot commented Aug 17, 2021

Uh oh!

m2-assistant bot commented Aug 17, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

andrewbess commented Aug 12, 2021 •

edited

Loading