32855: upgrade to the latest moment-timezone-with-data.js

[karyna-t]

Description (*)

Upgraded version of moment-timezone-with-data.js library (from 0.5.5 to 0.5.33).

Fixed Issues (if relevant)

1. Fixes Investigate upgrade to the latest moment-timezone-with-data.js #32855: Investigate upgrade to the latest moment-timezone-with-data.js

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @karyna-tsymbal-atwix. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me platform-health instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[karyna-t]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[karyna-t]

@magento run Functional Tests EE

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[karyna-t]

@magento run Functional Tests EE

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[karyna-t]

@magento run Functional Tests B2B

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[karyna-t]

@magento run Functional Tests B2B

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[ihor-sviziev]

✔ Approved.

Failing tests looks not related to changes from this PR.

[hostep]

Hmm, this is a minified js file, we should either:

• use the non-minified js file (so it's easier to understand the diff when it gets updated again in the future)
• if a non-minified js file is not available, indicate this is a minified js file by making sure the filename ends on .min.js so Magento's JS minifier does not try to minify it again in the SCD process (which can sometimes lead to unexpected bugs)

This remark does not only count for this PR, but for all PR's that are touching JS libraries (which seem to be quite popular these last few weeks, maybe @ihor-sviziev can try to communicate this to the people who are involved with this process?). Reasoning is explained briefly in #33427 (comment)

Does this remark make sense?

[ihor-sviziev]

@hostep, I Absolutely agree with you!

[ihor-sviziev]

Would you please adjust your PR according to the requested changes in #33476 (comment) ?

[karyna-t]

@hostep @ihor-sviziev Thank you for the notice! I'll keep it in mind.
I've update PR with a non-minified version of the file.

[andrewbess]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[Den4ik]

@karyna-tsymbal-atwix Could you please update file from minified version?

[Den4ik]

I missed the comment #33476 (comment) and it's really make sense.
@karyna-tsymbal-atwix Thanks for contribution

[m2-assistant]

Hi @karyna-tsymbal-atwix, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.