Skip to content

Constructor shoud use an interface #2990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 2, 2016
Merged

Constructor shoud use an interface #2990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/internal/Magento/Framework/ObjectManager/Definition/Compiled.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,15 @@ abstract class Compiled implements \Magento\Framework\ObjectManager\DefinitionIn
protected $_definitions;

/**
* @var \Magento\Framework\Code\Reader\ClassReader
* @var \Magento\Framework\Code\Reader\ClassReaderInterface
*/
protected $reader ;

/**
* @param array $definitions
* @param \Magento\Framework\Code\Reader\ClassReader $reader
* @param \Magento\Framework\Code\Reader\ClassReaderInterface $reader
*/
public function __construct(array $definitions, \Magento\Framework\Code\Reader\ClassReader $reader = null)
public function __construct(array $definitions, \Magento\Framework\Code\Reader\ClassReaderInterface $reader = null)
{
list($this->_signatures, $this->_definitions) = $definitions;
$this->reader = $reader ?: new \Magento\Framework\Code\Reader\ClassReader();
Expand Down
4 changes: 2 additions & 2 deletions lib/internal/Magento/Framework/ObjectManager/Definition/Runtime.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ class Runtime implements \Magento\Framework\ObjectManager\DefinitionInterface
protected $_definitions = [];

/**
* @param \Magento\Framework\Code\Reader\ClassReader $reader
* @param \Magento\Framework\Code\Reader\ClassReaderInterface $reader
*/
public function __construct(\Magento\Framework\Code\Reader\ClassReader $reader = null)
public function __construct(\Magento\Framework\Code\Reader\ClassReaderInterface $reader = null)
{
$this->_reader = $reader ?: new \Magento\Framework\Code\Reader\ClassReader();
}
Expand Down
6 changes: 3 additions & 3 deletions lib/internal/Magento/Framework/ObjectManager/Relations/Runtime.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
class Runtime implements \Magento\Framework\ObjectManager\RelationsInterface
{
/**
* @var \Magento\Framework\Code\Reader\ClassReader
* @var \Magento\Framework\Code\Reader\ClassReaderInterface
*/
protected $_classReader;

Expand All @@ -20,9 +20,9 @@ class Runtime implements \Magento\Framework\ObjectManager\RelationsInterface
protected $_default = [];

/**
* @param \Magento\Framework\Code\Reader\ClassReader $classReader
* @param \Magento\Framework\Code\Reader\ClassReaderInterface $classReader
*/
public function __construct(\Magento\Framework\Code\Reader\ClassReader $classReader = null)
public function __construct(\Magento\Framework\Code\Reader\ClassReaderInterface $classReader = null)
{
$this->_classReader = $classReader ?: new \Magento\Framework\Code\Reader\ClassReader();
}
Expand Down