Remove unneccessary overflowed class from minicart sidebar widget

[lumnn]

Description (*)

After investigating minibasket sidebar widget I've noticed isOverflowed function that applies overflowed class to one of minibasket elements.

Searching further, it seems that the class or even the word overflowed in any case is not used anywhere in magento2 repository.

As I'm seeking any performance improvements for my personal Magento 2 project I thought it will be worth to submit the changes.

Manual testing scenarios (*)

Can't think of any real testing scenarios. All I've done is I've kept adding products to basket to see if it changes at all the look and behaviour of minibasket

Questions or comments

• Do I check the checklist below now, later, or wait for some maintainer to check them for me?
• This may break custom themes that expect overflowed class. However, I believe if custom theme want's this behaviour, then it should extend the JS widget.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] Remove unneccessary overflowed class from minicart sidebar widget #29160: Remove unneccessary overflowed class from minicart sidebar widget

[m2-assistant]

Hi @lumnn. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

[lumnn]

@magento run all tests

[ptylek]

Seems that test fails are not related to this PR. Nice catch!

[magento-engcom-team]

Hi @ptylek, thank you for the review.
ENGCOM-7771 has been created to process this Pull Request
✳️ @ptylek, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[engcom-Delta]

✔️ QA passed
Was checked that minicart works as before on luma and blank themes
Luma:

Blank:

[engcom-Kilo]

@lumnn Please write issue number, if exist.

[VladimirZaets]

@magento create issue

[engcom-Kilo]

@magento run all tests

[engcom-Kilo]

Failed Functional Tests B2B - not related to changes in this Pull Request.

[m2-assistant]

Hi @lumnn, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.