-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Cleanup html class duplicate #28623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup html class duplicate #28623
Conversation
|
Hi @mrtuvn. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. |
|
@magento create issue |
ihor-sviziev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mrtuvn,
Could you squash all your changes to single commit? 16 commits just for changing one word seems to me too much.
164abb1 to
bc4b043
Compare
|
Hi @mrtuvn, thank you for your contribution! |
|
@ihor-sviziev moved to new PR #28639 |
Description (*)
Clean up class html
block class should be represent correct context inside
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)
Resolved issues: