Skip to content

Conversation

@mrtuvn
Copy link
Contributor

@mrtuvn mrtuvn commented Jun 8, 2020

Description (*)

Clean up class html
block class should be represent correct context inside

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Incorrect CSS selector in shipment page #28345

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Cleanup html class duplicate #28625: Cleanup html class duplicate

@m2-assistant
Copy link

m2-assistant bot commented Jun 8, 2020

Hi @mrtuvn. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@VladimirZaets
Copy link
Contributor

@magento create issue

@ghost ghost mentioned this pull request Jun 8, 2020
4 tasks
@ihor-sviziev ihor-sviziev self-assigned this Jun 9, 2020
@ihor-sviziev ihor-sviziev added Cleanup Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Jun 9, 2020
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mrtuvn,
Could you squash all your changes to single commit? 16 commits just for changing one word seems to me too much.

@mrtuvn mrtuvn force-pushed the cleanup-html-class-duplicate branch from 164abb1 to bc4b043 Compare June 9, 2020 14:35
@mrtuvn mrtuvn closed this Jun 9, 2020
@mrtuvn mrtuvn deleted the cleanup-html-class-duplicate branch June 9, 2020 14:39
@m2-assistant
Copy link

m2-assistant bot commented Jun 9, 2020

Hi @mrtuvn, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Jun 9, 2020

@ihor-sviziev moved to new PR #28639

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Component: LoginAsCustomerAdminUi Component: Sales Progress: needs update Release Line: 2.4 Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Issue] Cleanup html class duplicate Incorrect CSS selector in shipment page

4 participants