CMS page URL rewrite deletion in setup area #2710
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion of URL rewrites will occur there
|
Thank you for the PR! We are currently waiting for the travis builds to work again, which should happen in a few days. Once that is running and the tests are green we can continue to process your contribution. |
|
Done! |
|
Just discovered that, while this fix is definitely needed, it still does not result in the deletes being run properly, because a "setup" area is never defined to load XML files from. See issue #2725. |
|
Hello @CNanninga, can you please update the code and cover it by Travis tests? |
|
Closed as issue #2725 already fixed |
magento-engcom-team
pushed a commit
that referenced
this pull request
Jun 15, 2018
[panda] MAGETWO-89905: Categories of the Main menu in the different Store View not updated when varnish enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added CMS page URL rewrite plugin to setup area as well, so that deletion of URL rewrites will occur there