Skip to content

have_innodb variable is deprecated and removed in MySQL 5.6. #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

erenkarayigit
Copy link

@jeffmoser
Copy link

This is a critical issue that effectively prevents installation to anyone using MySQL 5.6 and aren't able to fix the issue on their own. MySQL 5.6 was released in 2011. erenkarayigit committed a working change six months ago, but nobody has even been assigned to review it.

I don't mean for this to sound like an angry rant, but I'm wondering:

  • is anyone assigned to the CE is monitoring the repo?
  • what unaddressed issues might be lurking after installation?
  • is there any type of regular release schedule for the CE?

@verklov
Copy link
Contributor

verklov commented Nov 7, 2013

Hello erenkarayigit,
Sorry for the delay with the response.
Thank you for your contribution! Our team will review your pull request and respond as soon as our analysis is complete.

@verklov
Copy link
Contributor

verklov commented Dec 1, 2013

Hello erenkarayigit,
We have this fix already in the code on Magento 2:
$variables = $this->_getConnection()->fetchPairs('SHOW ENGINES');
return isset($variables['InnoDB']) && ($variables['InnoDB'] == 'DEFAULT' || $variables['InnoDB'] == 'YES');

Thank you for your contribution and participation in Magento product development!

@verklov verklov closed this Dec 1, 2013
magento-team pushed a commit that referenced this pull request Apr 30, 2015
[Tango] S51 Controller Refactoring, Exception Handling in Phrases
mmansoor-magento pushed a commit that referenced this pull request Aug 22, 2016
Story:
MAGETWO-56012 SearchCriteria Unified Processing
MAGETWO-56079 SearchCriteria Unified Processing for Cms, Customer and Eav modules
MAGETWO-56080 SearchCriteria Unified Processing for GiftWrapping, Quote and Tax modules
MAGETWO-56081 SearchCriteria Unified Processing for autogenerated repositories of GiftCardAccount, Rma and Sales modules
MAGETWO-56082 SearchCriteria Unified Processing for Rma, Sales, SalesRule and Staging modules
MAGETWO-56083 SearchCriteria Unified Processing for Ui, Vault, and VersionsCms modules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants