Skip to content

Remove requirement of always available SPL extension #24870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 18, 2019
Merged

Remove requirement of always available SPL extension #24870

merged 3 commits into from
Oct 18, 2019

Conversation

@carusogabriel
Copy link
Contributor

@carusogabriel carusogabriel commented Oct 5, 2019

Description (*)

Since PHP 5.3.0, the SPL extension is always available and it can not be disabled.

Ref: https://php.net/manual/en/spl.installation.php

Fixed Issues (if relevant)

None

Manual testing scenarios (*)

Not necessary

Questions or comments

None

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Oct 5, 2019

Hi @carusogabriel. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@m2-assistant
Copy link

m2-assistant bot commented Oct 5, 2019

Hi @carusogabriel, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@carusogabriel carusogabriel reopened this Oct 5, 2019
@carusogabriel
Remove requirement of always available SPL extension
e737e7d 
Since PHP 5.3.0, the SPL extension is always available and it can not be disabled.

Ref: https://php.net/manual/en/spl.installation.php
@ghost ghost assigned aleron75 Oct 6, 2019
@aleron75 aleron75 added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Oct 6, 2019
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Oct 6, 2019

Hi @aleron75, thank you for the review.
ENGCOM-6018 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Oct 6, 2019

@carusogabriel thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@ghost
Copy link

ghost commented Oct 6, 2019

@carusogabriel unfortunately, only members of the maintainers team are allowed to remove progress related labels to the pull request

@engcom-Delta engcom-Delta self-assigned this Oct 9, 2019
@engcom-Delta
Copy link
Contributor

engcom-Delta commented Oct 9, 2019

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Oct 9, 2019

Hi @engcom-Delta. Thank you for your request. I'm working on Magento instance for you

@engcom-Delta
Copy link
Contributor

engcom-Delta commented Oct 9, 2019

Hi @carusogabriel . Could you resolve merge conflicts?

@engcom-Foxtrot engcom-Foxtrot self-assigned this Oct 11, 2019
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Oct 16, 2019

Hi @aleron75, thank you for the review.
ENGCOM-6018 has been created to process this Pull Request

@engcom-Delta
Copy link
Contributor

engcom-Delta commented Oct 16, 2019

✔️ QA passed

magento-engcom-team pushed a commit that referenced this pull request Oct 18, 2019
@VladimirZaets
ENGCOM-6018: Remove requirement of always available SPL extension #24870
f5a135c
@magento-engcom-team magento-engcom-team merged commit cccb287 into magento:2.3-develop Oct 18, 2019
@m2-assistant
Copy link

m2-assistant bot commented Oct 18, 2019

Hi @carusogabriel, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@buskamuza buskamuza Awaiting requested review from buskamuza

1 more reviewer

@aleron75 aleron75 aleron75 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@aleron75 aleron75

@engcom-Delta engcom-Delta

@engcom-Foxtrot engcom-Foxtrot

Labels

Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: Composer Progress: accept Release Line: 2.3 Squashtoberfest 2019

Projects

None yet

Milestone

Release: 2.3.4

Development

Successfully merging this pull request may close these issues.

5 participants

@carusogabriel @magento-engcom-team @engcom-Delta @aleron75 @engcom-Foxtrot