-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Correction in the shipping method if it is empty it no longer shows t… #24265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correction in the shipping method if it is empty it no longer shows t… #24265
Conversation
…he indefinite word
Hi @wbeltranc. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me, it's a good workaround.
Hi @aleron75, thank you for the review.
|
✔️ QA passed |
Hi @wbeltranc, thank you for your contribution! |
Description (*)
I propose to correct this problem is to validate if the title of the method was undefined, show the carrier title in the opposite case concatenate the method title with the carrier title
I solved it with the validation was done in the file Magento/Checkout/view/frontend/web/js/view/shipping-information.js in the getShippingMethodTitle method, I create a variable to concatenate the names.
Fixed Issues (if relevant)
Contribution checklist (*)