Skip to content

"Save Product" with the invalid data must scroll to the error message issue24241 #24242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

edenduong
Copy link
Contributor

@edenduong edenduong commented Aug 22, 2019

Description (*)

  1. Resolve "Save Product" with the invalid data must scroll to the error message #24241: "Save Product" with the invalid data must scroll to the error message

Solution: Use ScrollTop to the error message in app/code/Magento/Ui/view/base/web/js/form/client.js

Fixed Issues (if relevant)

  1. "Save Product" with the invalid data must scroll to the error message #24241: "Save Product" with the invalid data must scroll to the error message

Manual testing scenarios (*)

  1. Go to backend
  2. Create New Product
  3. Fill all required field
  4. Scroll down to "Schedule Design Update", fill date of "From" is greater than date of "To"
  5. Click Save

Expected result

  1. Scroll to the error message "Make sure the To Date is later than or the same as the From Date." so user can see the error message

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Aug 22, 2019

Hi @edenduong. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@edenduong
Copy link
Contributor Author

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @edenduong. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @edenduong, here is your new Magento instance.
Admin access: https://pr-24242.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@edenduong edenduong force-pushed the 2.3-bugfix/save_invalid_data_scroll_issue24241 branch from e846d70 to 157e1cd Compare August 22, 2019 15:35
@edenduong
Copy link
Contributor Author

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @edenduong. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @edenduong, here is your new Magento instance.
Admin access: https://pr-24242.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@kalpmehta kalpmehta self-assigned this Aug 22, 2019
@magento-engcom-team
Copy link
Contributor

Hi @kalpmehta, thank you for the review.
ENGCOM-5679 has been created to process this Pull Request
✳️ @kalpmehta, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Alfa
Copy link
Contributor

engcom-Alfa commented Aug 27, 2019

✔️ QA Passed

Actual Result:
after

@m2-assistant
Copy link

m2-assistant bot commented Aug 28, 2019

Hi @edenduong, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Aug 28, 2019
@sidolov sidolov added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Save Product" with the invalid data must scroll to the error message
6 participants