-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Fix: Update customer email in quote #24049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Update customer email in quote #24049
Conversation
Hi @UncleTioma. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
@magento give me test instance |
Hi @Stepa4man. Thank you for your request. I'm working on Magento instance for you |
Hi @Stepa4man, here is your new Magento instance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @UncleTioma, thanks for your contribution, could you please check failed tests? Except for DB checker, it has problems right now. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@UncleTioma
Please check 2 additional comments, and think about the following things:
Not sure, but if you start checkout with old email, fill quote addresses with default addresses going to the last checkout step and then interrupt checkout and change customer email in the customer account dashboard.
Should we also update quote_address records with the new email? Or it will be changed automatically? Could you please check this case?
Thanks in advance!
app/code/Magento/Customer/Observer/UpgradeQuoteCustomerEmailObserver.php
Show resolved
Hide resolved
It will be changed automatically. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check my comments. Thank you.
app/code/Magento/Customer/Observer/UpgradeQuoteCustomerEmailObserver.php
Show resolved
Hide resolved
app/code/Magento/Customer/Observer/UpgradeQuoteCustomerEmailObserver.php
Outdated
Show resolved
Hide resolved
app/code/Magento/Customer/Observer/UpgradeQuoteCustomerEmailObserver.php
Outdated
Show resolved
Hide resolved
app/code/Magento/Customer/Observer/UpgradeQuoteCustomerEmailObserver.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @UncleTioma,
Thanks for your contribution!
Hi @Stepa4man, thank you for the review.
|
@UncleTioma thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
✔️ QA Passed |
Hi @UncleTioma, thank you for your contribution! |
Description (*)
сustomer_email is not updated in
quote
andsales_order
tablesFixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)