Skip to content

Fix: Update customer email in quote #24049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

UncleTioma
Copy link
Contributor

@UncleTioma UncleTioma commented Aug 7, 2019

Description (*)

сustomer_email is not updated in quote and sales_order tables

Fixed Issues (if relevant)

  1. Customer email Address is not updated in quote and sales_order tables #24012: Customer email Address is not updated in quote and sales_order tables

Manual testing scenarios (*)

  1. Login to customer account
  2. Add some products to the cart
  3. Now move to My Account page.
  4. Go to Edit Account Information page & check Change Email checkbox
  5. Now change your email address & save your account information
  6. Now move to checkout & place Order

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Aug 7, 2019

Hi @UncleTioma. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@Stepa4man
Copy link
Contributor

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @Stepa4man. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @Stepa4man, here is your new Magento instance.
Admin access: https://pr-24049.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@Stepa4man Stepa4man self-assigned this Aug 7, 2019
Copy link
Contributor

@Stepa4man Stepa4man left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @UncleTioma, thanks for your contribution, could you please check failed tests? Except for DB checker, it has problems right now. Thanks!

Copy link
Contributor

@Stepa4man Stepa4man left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@UncleTioma
Please check 2 additional comments, and think about the following things:
Not sure, but if you start checkout with old email, fill quote addresses with default addresses going to the last checkout step and then interrupt checkout and change customer email in the customer account dashboard.
Should we also update quote_address records with the new email? Or it will be changed automatically? Could you please check this case?

Thanks in advance!

@UncleTioma
Copy link
Contributor Author

UncleTioma commented Aug 7, 2019

Should we also update quote_address records with the new email? Or it will be changed automatically?

It will be changed automatically.
@Stepa4man

Copy link
Contributor

@Stepa4man Stepa4man left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comments. Thank you.

Copy link
Contributor

@Stepa4man Stepa4man left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @UncleTioma,
Thanks for your contribution!

@magento-engcom-team
Copy link
Contributor

Hi @Stepa4man, thank you for the review.
ENGCOM-5591 has been created to process this Pull Request
✳️ @Stepa4man, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@magento-engcom-team
Copy link
Contributor

@UncleTioma thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@m2-assistant
Copy link

m2-assistant bot commented Aug 19, 2019

Hi @UncleTioma, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Aug 19, 2019
@sidolov sidolov added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Component: Customer Partner: Elogic partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants