[Lib] Fix previous attempts to correct wrong behaviour of collapsible library

[Den4ik]

Description (*)

This PR provide complete fix for wrong behaviour of collapsible library on product page and category page.
Previous fix was broke category page filter behaviour

Fixed Issues (if relevant)

1. Changed logic so that _scrollToTopIfVisible is called only if element is in viewport. Previously it was called only when the element was outside it. #23390

Manual testing scenarios (*)

1. Go to category page
2. Try to click onto filter headers
3. Expected that the page will not make strange jumps

Questions or comments

Expected result

Actual result

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @Den4ik. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[Den4ik]

@sidolov could you check this PR. Previous fix was broke catalog filters collapse

[magento-engcom-team]

Hi @VladimirZaets, thank you for the review.
ENGCOM-5600 has been created to process this Pull Request
✳️ @VladimirZaets, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[engcom-Alfa]

✔️ QA Passed

Before:

After:

[m2-assistant]

Hi @Den4ik, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[Karlasa]

@magento give me test instance

[magento-engcom-team]

Hi @Karlasa. Thank you for your request. I'm working on Magento instance for you

[Karlasa]

@magento give me 2.3-develop instance

[magento-engcom-team]

Hi @Karlasa. Thank you for your request. I'm working on Magento 2.3-develop instance for you

[magento-engcom-team]

Hi @Karlasa, here is your Magento instance.
Admin access: https://i-23862-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.