Skip to content

implement rss feed image size based on view.xml file #23533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 26 commits into from
Aug 14, 2019
Merged

implement rss feed image size based on view.xml file #23533

merged 26 commits into from
Aug 14, 2019

Conversation

sunilit42
Copy link
Contributor

Fixed Issues (if relevant)
#23516

I have installed the Magento 2.3.1.

I hav enabled the RSS Feed for the category and Product.

Preconditions
enabled the RSS Feed for the category and Product

Information on your environment
I have installed the Magento 2.3.1.

Steps to reproduce
Open the Rss feed Page : http://magento2jigar.com/rss/

Expected result (*)
It should take image size based on view.xml file

@m2-assistant
Copy link

m2-assistant bot commented Jul 2, 2019

Hi @sunilit42. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

sivaschenko
sivaschenko requested changes Jul 2, 2019
View reviewed changes
Copy link
Member

@sivaschenko sivaschenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sunilit42 thanks for the pull request. Please take a look at my review comments.

Also, pay attention there are failed static and unit tests for this PR

@sivaschenko sivaschenko self-assigned this Jul 2, 2019
sivaschenko
sivaschenko requested changes Jul 24, 2019
View reviewed changes
Copy link
Member

@sivaschenko sivaschenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sunilit42 thanks for fixing static tests, please take a look at my review comment.

app/code/Magento/Catalog/Block/Rss/Category.php Outdated
*
* @return \Magento\Framework\Config\View
*/
protected function getConfigView()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can _viewConfig property of the parent class can be used instead of introducing new dependency?

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-5569 has been created to process this Pull Request
✳️ @sivaschenko, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@sivaschenko sivaschenko added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Aug 8, 2019
@engcom-Alfa engcom-Alfa self-assigned this Aug 9, 2019
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Before:
before2

After:
after
after2

@engcom-Foxtrot engcom-Foxtrot self-assigned this Aug 12, 2019
@engcom-Foxtrot
Copy link
Contributor

@magento run all tests

@magento-engcom-team magento-engcom-team mentioned this pull request Aug 14, 2019
Closed
@magento-engcom-team magento-engcom-team merged commit f301d5f into magento:2.3-develop Aug 14, 2019
@m2-assistant
Copy link

m2-assistant bot commented Aug 14, 2019

Hi @sunilit42, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

taskula pushed a commit to Hypernova-Oy/magento2 that referenced this pull request Aug 14, 2019
@sidolov
ENGCOM-5569: implement rss feed image size based on view.xml file mag…
11862c3 
…ento#23533
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sivaschenko sivaschenko sivaschenko approved these changes

Assignees

@sivaschenko sivaschenko

@VladimirZaets VladimirZaets

@engcom-Alfa engcom-Alfa

@engcom-Foxtrot engcom-Foxtrot

Labels
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests Award: bug fix Component: Catalog Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.4
Development

Successfully merging this pull request may close these issues.
6 participants
@sunilit42 @magento-engcom-team @engcom-Alfa @engcom-Foxtrot @sivaschenko @VladimirZaets