#16832 - Reworked query in getAttributeRawValue so that it returns a store specific value even if there is no default value

[semajeg]

Description (*)

Reworked query in getAttributeRawValue so that it returns a store specific value even if there is no default value

The query being generated in this function was querying the default value and then joining onto the store value, so if the default value was not present then it would not return a store value, even if there was one.

The query has been changed so that it left joins on both the default value and the store value, so that it does not prevent the return of a store value if there is no default

Fixed Issues (if relevant)

1. Product resource getAttributeRawValue function does not return anything if there is no default value #16382: Product resource getAttributeRawValue function does not return anything if there is no default value

Manual testing scenarios

1. Create 2 store views (though 1 will do)
2. Create a product attribute with no default value, and a store view scope (e.g. a dropdown)
3. On a product, set a value in one of the child store views, and not at the default level
4. Call $resourceModel->getAttributeRawValue(, <attribute_code>, );

Questions or comments

Though the tech guidelines say "1.3.1. All new PHP files MUST have strict type mode enabled by starting with declare(strict_types=1);. All updated PHP files SHOULD have strict type mode enabled. PHP interfaces SHOULD NOT have this declaration.". This was discussed at the mm19uk contribution day with Tom Erskine and we decided that this PR should not do that to this file,since it will widen the scope of the PR too much and probably cause a LOT of knock on effects

[m2-assistant]

Hi @semajeg. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[magento-cicd2]

All committers have signed the CLA.

[semajeg]

Hey @dmanners, got a weird issue here. The "Database Compare Build" is failing now, but when you look at the details, it says it's all passed. Any thoughts?

[semajeg]

Hey @dmanners, got a weird issue here. The "Database Compare Build" is failing now, but when you look at the details, it says it's all passed. Any thoughts?

You can ignore this now @dmanners , all tests are now passing

[magento-engcom-team]

Hi @josefbehr, thank you for the review.
ENGCOM-5683 has been created to process this Pull Request
✳️ @josefbehr, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[engcom-Delta]

✔️ QA passed

[m2-assistant]

Hi @semajeg, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.