Skip to content

hide or show the select for regions instead of enabling/disabling in customer registration #23272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2019
Merged

hide or show the select for regions instead of enabling/disabling in customer registration #23272

merged 1 commit into from
Jul 10, 2019

Conversation

UB3RL33T
Copy link
Contributor

Description (*)

If you set the state options in Stores -> Configuration -> General -> General -> State Options and enable the address fields for customer registration the behaviour in the frontend differs from the behaviour in the checkout.
In the checkout the options are hidden if state is not required and not optional on the customer registration the dropdown is displayed but disabled.
This change should bring the customer registration more inline with the checkout behaviour.

Manual testing scenarios (*)

  1. enable address input in customer registration:

mytheme/src/Magento_Customer/layout/customer_account_create.xml

<?xml version="1.0"?>
<page xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:View/Layout/etc/page_configuration.xsd">
    <body>
        <referenceBlock name="customer_form_register">
            <arguments>
                <argument name="show_address_fields" xsi:type="boolean">true</argument>
            </arguments>
        </referenceBlock>
    </body>
</page>
  1. Go to customer registration https://example.com/customer/account/create/
    Use country select to swap between countries that have states required and states that have not
    The dropdown for regions will swap between enabled and disabled state.

Do the same in checkout, there the dropdown hides / shows

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jun 14, 2019

Hi @UB3RL33T. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jun 14, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@torhoehn torhoehn self-assigned this Jun 16, 2019
@torhoehn torhoehn self-requested a review June 16, 2019 21:39
@torhoehn
Copy link
Contributor

@UB3RL33T Thanks for your first contribution! Please sign the Contributor License Agreement.

@ghost ghost assigned sidolov Jul 5, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-5409 has been created to process this Pull Request
✳️ @sidolov, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@magento-engcom-team
Copy link
Contributor

@UB3RL33T thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@engcom-Alfa engcom-Alfa self-assigned this Jul 8, 2019
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Foxtrot engcom-Foxtrot self-assigned this Jul 8, 2019
@magento-engcom-team magento-engcom-team merged commit 447aac0 into magento:2.3-develop Jul 10, 2019
@m2-assistant
Copy link

m2-assistant bot commented Jul 10, 2019

Hi @UB3RL33T, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Jul 10, 2019
@sivaschenko
ENGCOM-5409: hide or show the select for regions instead of enabling/…
d47bbfb 
…disabling in customer registration #23272
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.3 milestone Jul 10, 2019
@VladimirZaets VladimirZaets added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidolov sidolov sidolov approved these changes

@torhoehn torhoehn Awaiting requested review from torhoehn

Assignees

@torhoehn torhoehn

@sidolov sidolov

@engcom-Alfa engcom-Alfa

@engcom-Foxtrot engcom-Foxtrot

Labels
Area: Frontend Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests Component: Checkout Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.3
Development

Successfully merging this pull request may close these issues.
8 participants
@UB3RL33T @magento-cicd2 @torhoehn @magento-engcom-team @engcom-Alfa @sidolov @VladimirZaets @engcom-Foxtrot